After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748658 - C++11 permits only explicit conversion of streams to bool
C++11 permits only explicit conversion of streams to bool
Status: RESOLVED FIXED
Product: libxml++
Classification: Bindings
Component: General
unspecified
Other Windows
: Normal normal
: ---
Assigned To: Christophe de Vienne
Christophe de Vienne
Depends on:
Blocks:
 
 
Reported: 2015-04-29 17:11 UTC by Mikhail Titov
Modified: 2015-04-30 15:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use good() instead of implicit bool conversion (1.01 KB, patch)
2015-04-29 17:11 UTC, Mikhail Titov 		none Details | Review

Description Mikhail Titov 2015-04-29 17:11:19 UTC 
Created attachment 302595 [details] [review]
Use good() instead of implicit bool conversion

libxml++/io/istreamparserinputbuffer.cc and alike have functions returning stream as bool which is not allowed by MS Visual C++ 2013 in particular. Though I believe it is not Windows specific. There is a good() alternative [1].
A proposed patch is attached.

[1] http://www.cplusplus.com/reference/ios/ios/good/
Comment 1 Murray Cumming 2015-04-30 15:52:47 UTC 
Thanks. Pushed. Please try create a git format-patch next time so I can just "git am" it.