GNOME Bugzilla – Bug 748582
Clicking failed updates notification only starts gnome-software
Last modified: 2015-05-01 11:03:57 UTC
# rpm -q gnome-software gnome-shell gnome-software-3.16.1-1.fc22.x86_64 gnome-shell-3.16.1-1.fc22.x86_64 I received a notification "An important software update has failed" and clicking it did not show any details, but only started gnome-software at its main entry screen. Suggestion: Clicking the notification should open a window where the failed update details are displayed.
A second notification is affected. The one after successfully applying offline updates. Immediately after logging in: | Software Updates Available 14:16 | something like "update have been installed"? Sorry, I forgot the 2nd sentence, because it didn't reappear afterwards. Clicking on it, gnome-software main screen was displayed. I had expected a summary about what the notification was about. Sort of an overview/history about what has been updated. # pkcon offline-status|head -2 Status: Success Updated libblockdev-utils-0.11-1.fc22.x86_64 # pkcon offline-status|wc -l 65
This may be related with bug 747148 which introduces a scrolled window to the error message dialog. But I've tested this notification dialog and have not noticed any problem. What was the real cause of the error? How to reproduce the problem? Have you clicked "Show Details" button or "OK"? Are you able to obtain an earlier version of gnome-software and check if the same problem exists?
I had asked about "belated notifications" on Fedora test@ list: https://lists.fedoraproject.org/pipermail/test/2015-April/thread.html#126148 It has been suggested that I file an upstream bug about gnome-software. I don't know whether the gnome-software package version I referred to is supposed to open a window with failed update details. > What was the real cause of the error? Good question. If I knew the reason for those notifications, I might find out. When I posted about it to test@ list, "pkcon offline-status" showed a failed update where a firefox package could not be found in the repository. I had applied that security update much earlier with "rpm" and a few days later once more with "dnf" instead of offline updates. I don't remember any "offline update" where something had failed. The notification came as a surprise. > How to reproduce the problem? I don't remember any failure during an offline update. Typically I update with "dnf", but when I told gnome-software to apply offline updates yesterday, it worked. However, as pointed out in comment 1, gnome-software did not offer any details when clicking the notification about successful/completed installation of the updates. > Have you clicked "Show Details" button or "OK"? Where? In the notification? There I can only click the notification, which starts gnome-software. > Are you able to obtain an earlier version of gnome-software and > check if the same problem exists? Look, I am just a sporadic user of gnome-software. I'm trying to make sense of some of the stuff that's being offered, and I've encountered some riddles. Different question: Which version of gnome-software is supposed to show "failed offline updates details" when there is a notification about such a failure?
(In reply to Michael Schwendt from comment #0) > # rpm -q gnome-software gnome-shell > gnome-software-3.16.1-1.fc22.x86_64 > gnome-shell-3.16.1-1.fc22.x86_64 > > I received a notification > > "An important software update has failed" > > and clicking it did not show any details, but only started gnome-software at > its main entry screen. > > Suggestion: Clicking the notification should open a window where the failed > update details are displayed. Thanks Michael. I've pushed https://git.gnome.org/browse/gnome-software/commit/?id=2cf4d54682d78d9effdf9c1b2fd0266c991ce930 which should fix this up.
Kalev - thanks for fixing this bug. By the way, if this is an issue of 3.16 then I suggest you to backport the fix to the 3.16 branch, too. Now not to leave Michael without explications: (In reply to Michael Schwendt from comment #3) > [...] I had > applied that security update much earlier with "rpm" and a few days later > once more with "dnf" instead of offline updates. This may be the way to reproduce the problem: dnf, yum and packagekit have their own databases of the software and if you use one of them the others may not notice that an update has already been installed. That's why there is a "Refresh" button. Of course this is not the only reason, another one was related with the old notifications being archived and reopened. > [...] > Different question: Which version of gnome-software is supposed to show > "failed offline updates details" when there is a notification about such a > failure? Every version. The only difference is how the "failed offline updates details" message dialog looks: in the latest version which you already have this dialog has the optionally scrollable contents. I was afraid that that fix has broken something and caused the dialog window not to appear at all but now I understand it is not related at all. With the next release I hope you will see both these fixes playing together.
> The only difference is how the "failed offline updates details" > message dialog looks: There was no such message dialog after I had clicked the notification. In this bug report I wrote: | I received a notification | | "An important software update has failed" That refers to GNOME Shell and the list of notifications that appears when clicking the small circle near the clock display. I can only dismiss/close the notifications there, not choose anything else about what to do with them. Hence I clicked it to learn more about what had happened: | and clicking it did not show any details, but only started gnome-software | at its main entry screen. I.e. it displayed the featured application and application categories. Made me scratch my head, since I had expected some details about the failed update. Where to find the details I was notified about? | Suggestion: Clicking the notification should open a window where the | failed update details are displayed. Can it be more clear? > in the latest version which you already have this dialog has > the optionally scrollable contents. I was afraid that that fix > has broken something and caused the dialog window not to appear at all Which is exactly what I reported! No such details dialog for me. With all due respect, make the best out of this bug report, please. Maybe Kalev's fix is right. I only described the user experience I've made so far, the major confusion these notifications cause. Sometimes they are late, sometimes there are two IMO redundant ones (e.g. about applied updates, and gnome-software did not a show details dialog about that either). > dnf, yum and packagekit have their own databases of the software I'm aware of that, but it doesn't explain the failed offline update that has gone unnoticed here. It _could not download_ a firefox package from the repo if pkcon may be believed. That is a completely different error than discovering that the system is up-to-date already. In either case, whether success or failure during offline update, all I had expected is a way to view the details after clicking on a notification. > and if you use one of them the others may not notice that an update > has already been installed. That's why there is a "Refresh" button. I don't think I used gnome-software prior to this "failed update" to schedule any "offline update". As I pointed out, I had installed updates manually. For several days, the firefox update has not been available in the repos due to a bug in the Fedora Updates System. Perhaps odd timing from PackageKit backend, although it did not fail because of the system being up-to-date already, it failed because of a repo download error. All that matters in this bug report is that clicking the notification should have displayed details. So, my suggestion: let's not waste time on this ticket anymore. If it's fixed, fine. I will play with gnome-software a bit more as time permits.
Btw, reading the comment on https://git.gnome.org/browse/gnome-software/commit/?id=2cf4d54682d78d9effdf9c1b2fd0266c991ce930 it sets the notification's default action to show the offline update status. I don't think I could have clicked a "Show Details" (or "Review" for successful updates) button, since there was no such button. I will watch out for such buttons in the future, however. The less notifications, the better. But if there are notifications, they should be interesting.
(In reply to Michael Schwendt from comment #7) > I don't think I could have clicked a "Show Details" (or "Review" for > successful updates) button, since there was no such button. Right, that's exactly what the commit is fixing. In that view, gnome-shell doesn't show any buttons and all we can work with is the "default action" -- clicking on the body of the notification. This commit now hooks that up properly.