After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748580 - mxf: fix leak in mxfmetadata
mxf: fix leak in mxfmetadata
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-28 09:34 UTC by Guillaume Desmottes
Modified: 2015-04-28 14:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mfx: fix descriptor leak (1.55 KB, patch)
2015-04-28 09:34 UTC, Guillaume Desmottes 		none Details | Review
mfx: fix descriptor leak (1.46 KB, patch)
2015-04-28 14:06 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2015-04-28 09:34:10 UTC 
.
Comment 1 Guillaume Desmottes 2015-04-28 09:34:29 UTC 
Created attachment 302507 [details] [review]
mfx: fix descriptor leak

Free the existing descriptor array, if any, before replacing it.

Fix leaks with the
validate.file.playback.scrub_forward_seeking.test-mpeg2-mp3_mxf scenario.
Comment 2 Thiago Sousa Santos 2015-04-28 13:07:53 UTC 
Review of attachment 302507 [details] [review]:

g_free is null safe. Could you submit another patch that removes the extra if checks?
Comment 3 Guillaume Desmottes 2015-04-28 14:06:35 UTC 
Created attachment 302515 [details] [review]
mfx: fix descriptor leak

Free the existing descriptor array, if any, before replacing it.

Fix leaks with the
validate.file.playback.scrub_forward_seeking.test-mpeg2-mp3_mxf scenario.
Comment 4 Thiago Sousa Santos 2015-04-28 14:56:21 UTC 
commit da113b5ad7976c001633c7f79a2b8b95935f8176
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Tue Apr 28 11:28:39 2015 +0200

    mxf: fix descriptor leak
    
    Free the existing descriptor array, if any, before replacing it.
    
    Fix leaks with the
    validate.file.playback.scrub_forward_seeking.test-mpeg2-mp3_mxf scenario.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748580