Created attachment 302426 [details] [review]
libsoup: Fix variable shadowing

This makes the code a little easier to read, and eliminates some
compiler warnings.

Created attachment 302427 [details] [review]
libsoup: Remove duplicate function declarations

The *_default_init() function is declared by G_DEFINE_INTERFACE, so
doesn’t have to be declared separately. This eliminates some compiler
warnings.

Created attachment 302428 [details] [review]
libsoup: Fix some old-style function declarations

Eliminate some compiler warnings.

Created attachment 302429 [details] [review]
libsoup: Fix a variable name in the documentation

Change the documentation and header file to match the function
definition; this fixes a gtk-doc warning, but introduces no functional
or API changes.

Created attachment 302430 [details] [review]
tests: Set default values for some variables

This eliminates a compiler warning about potentially using uninitialised
variables. It’s not actually possible for this happen (the variables are
only used on conditional paths with the same conditions as those where
they were previously set), but it’s easy enough to make this change to
shut the compiler up.

Attachment 302426 [details] pushed as af2f349 - libsoup: Fix variable shadowing
Attachment 302427 [details] pushed as 3913732 - libsoup: Remove duplicate function declarations
Attachment 302428 [details] pushed as 28d4943 - libsoup: Fix some old-style function declarations
Attachment 302429 [details] pushed as 62e2143 - libsoup: Fix a variable name in the documentation
Attachment 302430 [details] pushed as e4bf420 - tests: Set default values for some variables