Bug 748440 – JHBuild may crash on build failure when notification is enabled

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 748440 - JHBuild may crash on build failure when notification is enabled


Summary:	JHBuild may crash on build failure when notification is enabled


Status:	RESOLVED FIXED

Product:	jhbuild
Classification:	Infrastructure
Component:	general
Version:	unspecified
Hardware:	Other FreeBSD

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Jhbuild maintainers
QA Contact:	Jhbuild QA

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2015-04-25 04:23 UTC by Ting-Wei Lan
Modified:	2015-06-14 06:57 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Don't crash when the notification service is not available (1.24 KB, patch) 2015-05-02 09:30 UTC, Ting-Wei Lan	none	Details \| Review
Don't crash when the notification service is not available (1.22 KB, patch) 2015-05-02 09:57 UTC, Ting-Wei Lan	none	Details \| Review
Don't crash when the notification service is not available (1.83 KB, patch) 2015-06-06 15:20 UTC, Ting-Wei Lan	committed	Details \| Review

Description Ting-Wei Lan 2015-04-25 04:23:51 UTC

I set 'nonotify = False' in my jhbuildrc to enable notification, but it can cause jhbuild to crash with the following message:

*** Error during phase build of gnome-dictionary: ########## Error running gmake LIBTOOL=/usr/local/bin/libtool -j4  *** [120/208]
Traceback (most recent call last):

+ Trace 234999

File "/home/lantw44/.local/bin/jhbuild", line 32 in <module>
```
jhbuild.main.main(sys.argv[1:])
```
File "/home/lantw44/gnome/devinstall/lib/python2.7/site-packages/jhbuild/main.py", line 151 in main
```
rc = jhbuild.commands.run(command, config, args, help=lambda: print_help(parser))
```
File "/home/lantw44/gnome/devinstall/lib/python2.7/site-packages/jhbuild/commands/__init__.py", line 183 in run
```
return cmd.execute(config, args, help)
```
File "/home/lantw44/gnome/devinstall/lib/python2.7/site-packages/jhbuild/commands/__init__.py", line 52 in execute
```
return self.run(config, options, args, help)
```
File "/home/lantw44/gnome/devinstall/lib/python2.7/site-packages/jhbuild/commands/base.py", line 268 in run
```
return build.build()
```
File "/home/lantw44/gnome/devinstall/lib/python2.7/site-packages/jhbuild/frontends/buildscript.py", line 181 in build
```
altphases)
```
File "/home/lantw44/gnome/devinstall/lib/python2.7/site-packages/jhbuild/frontends/terminal.py", line 296 in handle_error
```
icon = 'dialog-error', expire = 20)
```
File "/home/lantw44/gnome/devinstall/lib/python2.7/site-packages/jhbuild/utils/notify.py", line 52 in notify
```
summary, body, [], {}, 1000*expire)
```
File "/home/lantw44/gnome/devinstall/lib/python2.7/site-packages/dbus/proxies.py", line 68 in __call__
```
return self._proxy_method(*args, **keywords)
```
File "/home/lantw44/gnome/devinstall/lib/python2.7/site-packages/dbus/proxies.py", line 140 in __call__
```
**keywords)
```
File "/home/lantw44/gnome/devinstall/lib/python2.7/site-packages/dbus/connection.py", line 630 in call_blocking
```
message, timeout)
```

dbus.exceptions.DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name :1.22 was not provided by any .service files



This usually happens when gnome-shell is restarting because of crash.

Comment 1 Ting-Wei Lan 2015-05-02 09:30:36 UTC

Created attachment 302751 [details] [review]
Don't crash when the notification service is not available

Comment 2 Ting-Wei Lan 2015-05-02 09:57:06 UTC

Created attachment 302752 [details] [review]
Don't crash when the notification service is not available

Sorry, the old patch was wrong.

Comment 3 Ting-Wei Lan 2015-06-06 15:20:22 UTC

Created attachment 304697 [details] [review]
Don't crash when the notification service is not available

Try to get a new iface when iface.Notify or iface.CloseNotification fails.

Comment 4 Ting-Wei Lan 2015-06-14 06:57:06 UTC

Attachment 304697 [details] pushed as 77c053c - Don't crash when the notification service is not available