GNOME Bugzilla – Bug 748394
New handling of $PKG_NAME is bogus
Last modified: 2015-04-24 14:20:27 UTC
I decided to try updating my autogen.sh to get rid of this nag: ***Warning*** PKG_NAME is deprecated, you may remove it from autogen.sh The new instructions for crafting an autogen.sh (from the README) look like this: #!/bin/sh srcdir=`dirname $0` [ -z "$srcdir" ] && srcdir=. if [ ! -f "$srcdir/configure.ac" ]; then echo "$srcdir doesn't look like source directory for $PKG_NAME" >&2 exit 1 fi which gnome-autogen.sh || { echo "You need to install gnome-common from GNOME Git" exit 1 } . gnome-autogen.sh "$@" But $PKG_NAME is used before it's defined, so that's problem #1. Then gnome-autogen.sh computes $PKG_NAME with some autoconf trickery: PKG_NAME=`autoconf --trace "AC_INIT:$1" "$srcdir/configure.ac"` Which expands to the string "--prefix": Epiphany was configured with the following options: Source code location : . Compiler : gcc Prefix : /home/mcatanzaro/jhbuild/install Extra debugging support : yes Build tests : yes Code coverage : no NSS support : yes Now type `make' to compile --prefix I think I will not update my autogen.sh quite yet. :)
Problem #1 is not a convern (and was not during the review of the initial patch), and I fied the second problem with commit 57403addd36276aac8fc52d200177fb6366d888d.
OK thanks for the fix. Why is problem #1 not a concern? A minor issue surely, but at the least, we should change it in the README to something like: echo "$srcdir doesn't look like source directory" >&2