After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748376 - Fix build problem when using clang in C++11 mode
Fix build problem when using clang in C++11 mode
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-23 16:17 UTC by Ting-Wei Lan
Modified: 2015-04-23 16:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH 1/2] build: Fix build when using C++11 mode (3.30 KB, patch)
2015-04-23 16:21 UTC, Ting-Wei Lan 		committed Details | Review
[PATCH 2/2] build: Add libc++ check to check-libstdc++.sh (973 bytes, patch)
2015-04-23 16:21 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2015-04-23 16:17:45 UTC 
I got this error when compiling vte with 'clang++ -std=c++11':

vtedraw.cc:1499:41: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
                g_printerr ("draw_text (\"%s\", len=%"G_GSIZE_FORMAT", color=(%d,%d,%d,%d), %s - %s)\n",
                                                      ^

The attached patch fixes this problem.

I also modified check-libstdc++.sh to make it check both libstdc++ and libc++, so it can be useful on FreeBSD 10 and later versions.
Comment 1 Ting-Wei Lan 2015-04-23 16:21:01 UTC 
Created attachment 302236 [details] [review]
[PATCH 1/2] build: Fix build when using C++11 mode
Comment 2 Ting-Wei Lan 2015-04-23 16:21:24 UTC 
Created attachment 302237 [details] [review]
[PATCH 2/2] build: Add libc++ check to check-libstdc++.sh
Comment 3 Christian Persch 2015-04-23 16:48:29 UTC 
Comment on attachment 302237 [details] [review]
[PATCH 2/2] build: Add libc++ check to check-libstdc++.sh

Ok. (Although it's likely I'll remove this check and actually use libstdc++, soon.)
Comment 4 Ting-Wei Lan 2015-04-23 16:52:58 UTC 
Attachment 302236 [details] pushed as 42ecf1a - build: Fix build when using C++11 mode
Attachment 302237 [details] pushed as 5a58273 - build: Add libc++ check to check-libstdc++.sh