GNOME Bugzilla – Bug 748306
Don't mix raised buttons with non-raised ones
Last modified: 2015-08-31 15:01:24 UTC
The playback controls bar includes a mixture of buttons styles - some buttons are raised (ie. have relief), while others don't. This is a bit inconsistent. Buttons generally have relief in GNOME 3 - it would be best to use relief on all of them in the play controls bar.
Created attachment 310166 [details] [review] backend: Don't flatten OSD buttons
Two problems though. First, Adwaita adds the "flat" CSS style to the volume button at the end of the OSD, probably because it's the last item in the toolbar (?). Second, even if you manage to fix that, because the buttons aren't linked, it looks bad. We need to add some padding or something.
(In reply to Bastien Nocera from comment #2) > Two problems though. > > First, Adwaita adds the "flat" CSS style to the volume button at the end of > the OSD, probably because it's the last item in the toolbar (?). > > Second, even if you manage to fix that, because the buttons aren't linked, > it looks bad. We need to add some padding or something. Got a screenshot of this?
Created attachment 310176 [details] osd toolbar
Fixed in a different way in commit e562f02
Just for future reference, the volume button default look is flat, so this is not actually a bug.
(In reply to Lapo Calamandrei from comment #6) > Just for future reference, the volume button default look is flat, so this > is not actually a bug. What isn't actually a bug?
Did you mean to comment on bug 754225 instead?
gaaah, exactly Bastien, sorry for the noise. Mental note, don't comment bug using the phone...
So, should the volume button have a flat look or not? It currently looks bad right next to the "..." button.
commit 5208baf642701757a0f6de5030183734b93fc3f0 Author: Bastien Nocera <hadess@hadess.net> Date: Mon Aug 31 16:57:44 2015 +0200 backend: Re-flatten the volume button It's supposed to be flat. https://bugzilla.gnome.org/show_bug.cgi?id=748306