After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748300 - Unbreak loading Google and SkyDrive items from the cache
Unbreak loading Google and SkyDrive items from the cache
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.14.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-04-22 14:07 UTC by Debarshi Ray
Modified: 2015-04-22 16:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
pdf-loader: Unbreak loading Google and SkyDrive items from the cache (2.87 KB, patch)
2015-04-22 14:12 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2015-04-22 14:07:22 UTC
We are supposed to fall back to the cache if we fail to create a GDataEntry or ZpjEntry (possibly due to lack of a network). This works by passing the nao:identifier to GdPdfLoader as an URI. This doesn't work any more because we broke the logic in:

commit 53a17bdb40d5f82f8ac8f655afc657bcf835da22
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Mon Aug 19 12:01:40 2013 +0200

    lib: support loading non-native GVfs URIs
    
    Even though libview has EvJobLoadGFile, it doesn't really work. eg.,
    PDFs fail to load over WebDAV. So, we download the files and convert
    them to PDF using unoconv, if needed, before showing them.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=686527
Comment 1 Debarshi Ray 2015-04-22 14:12:33 UTC
Created attachment 302156 [details] [review]
pdf-loader: Unbreak loading Google and SkyDrive items from the cache
Comment 2 Cosimo Cecchi 2015-04-22 16:28:02 UTC
Review of attachment 302156 [details] [review]:

Looks good to me