After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748252 - Fix the inconsistent brackets
Fix the inconsistent brackets
Status: RESOLVED FIXED
Product: gnome-sudoku
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Sahil Sareen
gnome-sudoku-maint
Depends on:
Blocks:
 
 
Reported: 2015-04-21 14:56 UTC by Sahil Sareen
Modified: 2015-04-22 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix inconsistent patch (8.74 KB, patch)
2015-04-21 14:58 UTC, Sahil Sareen 		accepted-commit_now Details | Review
Fix inconsistent code (18.47 KB, patch)
2015-04-22 11:39 UTC, Sahil Sareen 		accepted-commit_now Details | Review

Description Sahil Sareen 2015-04-21 14:56:02 UTC 
Lots of sudoku code is inconsistent in braces and needs to be fixed.
Comment 1 Sahil Sareen 2015-04-21 14:58:47 UTC 
Created attachment 302075 [details] [review]
Fix inconsistent patch
Comment 2 Michael Catanzaro 2015-04-21 15:25:09 UTC 
Review of attachment 302075 [details] [review]:

Thanks for taking the time to clean up the little things :)

::: lib/sudoku-board.vala
@@ +390,1 @@
                 occurances.add (coord);

I suggest no brackets at all when the conditional is exactly one line long, with no comment inside the conditional.
Comment 3 Sahil Sareen 2015-04-22 11:39:28 UTC 
Created attachment 302142 [details] [review]
Fix inconsistent code

*(mcatanzaro) Single line after conditional -> No brackets
Comment 4 Sahil Sareen 2015-04-22 11:54:53 UTC 
Pushed to master.

To ssh://ssareen@git.gnome.org/git/gnome-sudoku
   c5ce94e..51090da  master -> master