After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748227 - tracker-extract: Only extract media art if artist or title is known
tracker-extract: Only extract media art if artist or title is known
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Extractor
unspecified
Other All
: Normal normal
: ---
Assigned To: tracker-extractor
tracker-extractor
Depends on:
Blocks:
 
 
Reported: 2015-04-21 07:15 UTC by Philip Withnall
Modified: 2015-04-23 23:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tracker-extract: Only extract media art if artist or title is known (1.39 KB, patch)
2015-04-21 07:15 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2015-04-21 07:15:54 UTC
Trivial patch attached.
Comment 1 Philip Withnall 2015-04-21 07:15:57 UTC
Created attachment 302047 [details] [review]
tracker-extract: Only extract media art if artist or title is known

media_art_process_*() require at least one of the track’s artist and
title to be specified, and will fail an assertion precondition if both
are NULL.

Other tracker-extract-*.c media backends already do this check, but it
was missing from the GStreamer extractor.
Comment 2 Martyn Russell 2015-04-23 20:42:09 UTC
Review of attachment 302047 [details] [review]:

Thanks for the patch Philip!
Comment 3 Philip Withnall 2015-04-23 23:10:58 UTC
Attachment 302047 [details] pushed as d7159fe - tracker-extract: Only extract media art if artist or title is known