GNOME Bugzilla – Bug 748206
Printer list in "Add Printer" dialog is not focusable only with keyboard.
Last modified: 2015-06-10 09:40:18 UTC
Created attachment 302019 [details] Screenshot of the dialog Dear developers, i try to add an printer with the gcc. i cannot navigate to the printerlist just with the keyboard. i tried tab/ ctrl + tab and the arrow keys (and some other things). i m blind. so i cant use the mouse. sighted people tells me that my printer is shown in that list. i m just unable to navigate to the printer list (shown in the screenshot). after pressing alt + tab it seems to be focused but it is not. after klicking on the printer list orca is just able to say "icon" reproduce: 1. open gcc -> printer 2. press "add" 3. try to navigate to printer list
Created attachment 304176 [details] [review] Set focus of the 'New printer dialog' correctly This patch calls gtk_widget_show_all() on the 'New printer dialog' after setting transient parent for it so that the warning about missing transient parent is not shown to the user and the dialog is correctly focused.
Created attachment 304178 [details] [review] Fix focus chain of the 'New printer dialog' This one disables 'can-focus' for widgets which don't need that in the 'New printer dialog'. This fixes focus chain for me.
Created attachment 304179 [details] [review] Install selected printer when the row is activated And this one allows user to install printer by activating a row with a device.
Review of attachment 304176 [details] [review]: ok
Review of attachment 304179 [details] [review]: looks fine
Review of attachment 304178 [details] [review]: looks good
Thank you for the review. I've pushed the patches to master and the first 2 patches also to 3.16 branch (the third one is kind of feature). I'm closing this as fixed.