After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748192 - [PATCH] core: mgt_path free mgt_path on disconnect
[PATCH] core: mgt_path free mgt_path on disconnect
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: openvpn
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2015-04-20 15:22 UTC by Lubomir Rintel
Modified: 2015-04-22 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] core: mgt_path free mgt_path on disconnect (1.27 KB, patch)
2015-04-20 15:22 UTC, Lubomir Rintel 		none Details | Review

Description Lubomir Rintel 2015-04-20 15:22:07 UTC 
Created attachment 302004 [details] [review]
[PATCH] core: mgt_path free mgt_path on disconnect

We assert it's NULL on connect, triggering an assert fail on reconnect:

  (nm-openvpn-service:31948): nm-openvpn-WARNING **: (nm-openvpn-service.c:1194):
      nm_openvpn_start_openvpn_binary: runtime check failed: (priv->mgt_path == NULL)
---
 src/nm-openvpn-service.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 1 Dan Williams 2015-04-21 20:41:47 UTC 
LGTM
Comment 2 Thomas Haller 2015-04-22 07:06:04 UTC 
LGTM too
Comment 3 Lubomir Rintel 2015-04-22 15:54:43 UTC 
31f264a core: mgt_path free mgt_path on disconnect