After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748156 - Code cleanup after xp drop
Code cleanup after xp drop
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
3.16.x
Other Windows
: Normal minor
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-04-20 00:16 UTC by Jose Rostagno
Modified: 2015-04-27 10:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Simplify code a bit after xp support drop (1.96 KB, patch)
2015-04-20 00:16 UTC, Jose Rostagno
committed Details | Review
WM_CLIPBOARDUPDATE is always define on vista (789 bytes, patch)
2015-04-20 00:17 UTC, Jose Rostagno
accepted-commit_now Details | Review
drop old compat code (1.54 KB, patch)
2015-04-20 00:46 UTC, Jose Rostagno
accepted-commit_now Details | Review
HAVE_MONITOR_INFO is always defined (1.94 KB, patch)
2015-04-20 00:52 UTC, Jose Rostagno
committed Details | Review

Description Jose Rostagno 2015-04-20 00:16:46 UTC
Created attachment 301959 [details] [review]
Simplify code a bit after xp support drop

Some minor code simplifications after xp support drop
Comment 1 Jose Rostagno 2015-04-20 00:17:53 UTC
Created attachment 301960 [details] [review]
WM_CLIPBOARDUPDATE is always define on vista
Comment 2 Jose Rostagno 2015-04-20 00:46:53 UTC
Created attachment 301961 [details] [review]
drop old compat code
Comment 3 Jose Rostagno 2015-04-20 00:52:36 UTC
Created attachment 301962 [details] [review]
HAVE_MONITOR_INFO is always defined
Comment 4 Matthias Clasen 2015-04-20 00:58:00 UTC
Review of attachment 301959 [details] [review]:

looks good to me.
Comment 5 Matthias Clasen 2015-04-20 00:59:15 UTC
Review of attachment 301960 [details] [review]:

looks good to me
Comment 6 Matthias Clasen 2015-04-20 01:00:13 UTC
Review of attachment 301961 [details] [review]:

looks good to me
Comment 7 Matthias Clasen 2015-04-20 01:01:26 UTC
Review of attachment 301962 [details] [review]:

looks good to me
Comment 8 Jose Rostagno 2015-04-23 15:20:03 UTC
if they are ok, someone could push this?
Comment 9 Matthias Clasen 2015-04-27 10:41:06 UTC
Attachment 301959 [details] pushed as bc1ac40 - Simplify code a bit after xp support drop
Attachment 301962 [details] pushed as 7a6aee1 - HAVE_MONITOR_INFO is always defined