After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 74814 - table caption property doesn't seem to work
table caption property doesn't seem to work
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: gail
0.9
Other Linux
: Normal normal
: ---
Assigned To: padraig.obriain
padraig.obriain
: 75953 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-03-15 17:51 UTC by Damon Chaplin
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (2.79 KB, patch)
2003-01-15 11:13 UTC, padraig.obriain
none Details | Review

Description Damon Chaplin 2002-03-15 17:51:49 UTC
In Glade I have this code to get the table caption from a GtkTreeView's
AtkObject:

      g_object_get (G_OBJECT (atko),
		    "AtkObject::accessible-table-caption", &table_caption,
		    NULL);

This results in a warning:

glade-2 (pid:1744): ** WARNING **:
atkobject.c:919:atk_object_real_get_property(): invalid property id 8 for
"accessible-table-caption" of type `GParamString' in `GailTreeView'

It also happens when I try to set the property.
Comment 1 padraig.obriain 2002-03-15 18:10:17 UTC
I have noticed that the trype of this property is defined incorrectly,
in that it is inconsistent with atk_table_get_caption().

Would fixing this count as an API change?

There are other properties in AtkObject which are not supported for
setting and getting:

accessible-table-column-description
accessible-table-column-header
accessible-table-row-description
accessible-table-row-header
accessible-table-summary

Will you also want to use these properties?
Comment 2 padraig.obriain 2002-03-15 18:15:04 UTC
Is it acceptable to you to call atk_table_get_caption() instead?
Comment 3 Damon Chaplin 2002-03-15 18:40:11 UTC
Why is the table caption an AtkObject?
What properties will it have that should be set in Glade?
I thought the table caption was just a string.

Using atk_table_get_caption() is probably OK.

Changing the property type probably would count as an API change,
I think.
Comment 4 padraig.obriain 2002-03-19 08:39:34 UTC
One reason to have it as an AtkObject is to allow for something other
than a string be the caption.

Comment 5 padraig.obriain 2003-01-15 11:12:17 UTC
*** Bug 75953 has been marked as a duplicate of this bug. ***
Comment 6 padraig.obriain 2003-01-15 11:13:08 UTC
Created attachment 13577 [details] [review]
Proposed patch
Comment 7 padraig.obriain 2003-01-15 11:15:05 UTC
The proposed patch adds a new property
accessible-table-caption-object. 

I suggest that this property be used instead of the broken
accessible-table-caption.

This patch will be applied after we branch after GNOME 2.2.
Comment 8 bill.haneman 2003-01-21 12:15:43 UTC
time to apply this patch now?
Comment 9 bill.haneman 2003-01-21 12:22:52 UTC
I see you just did :-)
Comment 10 padraig.obriain 2003-01-21 12:40:56 UTC
I have applied the patch to add a new property
accessible-table-caption-object.

I need to change GAIL to use that property before closing this bug. 
Comment 11 padraig.obriain 2003-01-21 16:13:47 UTC
I have committed changes to gailtreeview.c to use
accessible-tabkle-caption-object and added support for setting and
getting accessible-table-caption-object to atkobject.c.