After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748136 - Don't split strings
Don't split strings
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-19 11:08 UTC by Alexandre Franke
Modified: 2015-05-12 18:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't split strings (2.59 KB, patch)
2015-05-12 18:10 UTC, Alexandre Franke 		committed Details | Review

Description Alexandre Franke 2015-04-19 11:08:29 UTC 
src/search/gb-search-display-group.c line 181:
_("%"G_GUINT64_FORMAT" more")    results in "%" as the translatable string.

src/vim/gb-vim.c line 90:
_("%"G_GINT64_FORMAT" is invalid for %s")    results in "%" as the translatable string.

tools/ide-search.c line 64:
_("%"G_GSIZE_FORMAT" results\n")    results in "%" as the translatable string.
Comment 1 Christian Hergert 2015-04-19 19:42:21 UTC 
How do other applications deal with this? The format for a size_t is going to be different on 32-bit and 64-bit.
Comment 2 André Klapper 2015-04-20 20:55:22 UTC 
(In reply to Christian Hergert from comment #1)
> How do other applications deal with this?

https://bugzilla.gnome.org/buglist.cgi?bug_id=605547,639290,640808
Comment 3 Alexandre Franke 2015-04-21 11:42:43 UTC 
So the way Mathias fixed it in gdk_pixbuf was

-                                                    _("Color profile has invalid length '%" G_GSIZE_FORMAT "'."),
-                                                    icc_profile_size);
+                                                    _("Color profile has invalid length %d."),
+                                                    (gint)icc_profile_size);
Comment 4 Alexandre Franke 2015-04-21 11:45:05 UTC 
Commit is at https://git.gnome.org/browse/gdk-pixbuf/commit/?id=081ac784
Comment 6 Alexandre Franke 2015-05-12 18:10:49 UTC 
Created attachment 303277 [details] [review]
Don't split strings

That makes it actually possible to translate those
Comment 7 Christian Hergert 2015-05-12 18:34:05 UTC 
Review of attachment 303277 [details] [review]:

LGTM
Comment 8 Alexandre Franke 2015-05-12 18:35:49 UTC 
Attachment 303277 [details] pushed as 0e35c2b - Don't split strings