GNOME Bugzilla – Bug 748111
Use PKG_PROG_PKG_CONFIG for pkg-config detection
Last modified: 2016-03-25 10:48:03 UTC
Created attachment 301906 [details] [review]
Using the PKG_PROG_PKG_CONFIG macro instead of AC_PATH_PROG allows easy cross-compilation since it also looks for a pkg-config binary prefixed with the given host-triplet (e.g. i686-pc-linux-gnu-pkg-config when passing --host=i686-pc-linux-gnu to cross-compile for x86)
Where is PKG_PROG_PKG_CONFIG defined? Wouldn't this cause an unintelligible error if pkg-config.m4 (or whatever) isn't installed?
The PKG_PROG_PKG_CONFIG macro is defined in pkg.m4 shipped with pkg-config. And sure, as every other macro it has to be available when (re)generating the autotools files. But it's not possible to do so without having that macro since other macros such as GTK_DOC_CHECK and VAPIGEN_CHECK use PKG_PROG_PKG_CONFIG as well
Okay, sounds fine.
pushed as cdf7b1cf2b33c36638775227a30ba3e0bea50e8c
Review of attachment 301906 [details] [review]:
Thanks for pushing!