After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748078 - "Pull Requests" functionality should not be available on github
"Pull Requests" functionality should not be available on github
Status: RESOLVED FIXED
Product: sysadmin
Classification: Infrastructure
Component: Git
unspecified
Other Windows
: Normal normal
: ---
Assigned To: GNOME Sysadmins
GNOME Sysadmins
Depends on:
Blocks:
 
 
Reported: 2015-04-17 20:22 UTC by Christian Stadelmann
Modified: 2016-12-07 13:09 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Stadelmann 2015-04-17 20:22:30 UTC
On GNOME repositories mirrored to github there is a "Pull Requests" feature available, e.g. for gnome-shell [1].
github users tend to think those pull requests would be read by gnome developers which they often are not. Instead [2] suggest to submit patches by gnome bugzilla. Could you please either forward those pull requests to gnome developers or disable this feature on github?

[1] https://github.com/GNOME/gnome-shell/pulls
[2] https://wiki.gnome.org/Sysadmin/GitHub
Comment 1 Andrea Veri 2015-04-21 10:44:01 UTC
This is indeed a problem, Christian. I got in touch with GitHub and seems they still aren't able to take pull requests off from a specific repository or organization. They proposed to include a CONTRIBUTING.md file to each repository stating what the guidelines for contributing to the GNOME Project are. We could probably go that way until the new feature is added on GitHub itself. Suggestions are welcome.
Comment 2 Kunaal Jain 2015-10-18 19:22:12 UTC
(In reply to Andrea Veri from comment #1)
> This is indeed a problem, Christian. I got in touch with GitHub and seems
> they still aren't able to take pull requests off from a specific repository
> or organization. They proposed to include a CONTRIBUTING.md file to each
> repository stating what the guidelines for contributing to the GNOME Project
> are. We could probably go that way until the new feature is added on GitHub
> itself. Suggestions are welcome.

Andrea, you can perhaps create a listener to github PR hooks, and when PR is made, makes a comment to that PR, about guidelines on submitting this to GNOME. With rich Github API and webhook, this will be a cakewalk. This is something we did for my GSoC project in CentOS [0]. Facebook Github repo does similar thing, though they do this to make them sign the CLA [1].

[0] https://github.com/yangl1996/docs-toolchain
[1] https://github.com/facebook/react-native/pulls
Comment 3 Tom Tryfonidis 2016-09-30 12:14:37 UTC
Here is OpenStack's approach to the issue. [1] The script is part of their Gerrit management tools [2], but i think it can work with GNOME's infrastructure.

[1] http://git.openstack.org/cgit/openstack-infra/jeepyb/tree/jeepyb/cmd/close_pull_requests.py
[2] http://docs.openstack.org/infra/system-config/jeepyb.html