GNOME Bugzilla – Bug 748050
[review] make ignore-carrier configuration reloadable
Last modified: 2015-05-05 14:59:26 UTC
Seems a nice and easy feature. Especially since we have NM-config-server that brings this configuration. Maybe %post install of the configuration should send SIGHUP to NetworkManager.
Created attachment 301830 [details] [review] config: make ignore-carrier option reloadable Only move the ignore-carrier option from NMConfig to NMConfigData. The ignore-carrier option is still immutable after startup.
Created attachment 301831 [details] [review] device: allow reloading of the ignore-carrier flag Now on SIGHUP, when reloading NetworkManager configuration, also reload the ignore-carrier flag. While a device is activated, the reload is ignored until the device deactivates. Maybe it would be simpler just not to cache ignore_carrer and let it take effect immediately. But not caching ignore_carrer has the additional downside that every call to is_available must check the specs -- which in sum is potentially expensive for something that almost never changes.
Review of attachment 301830 [details] [review]: LGTM
Review of attachment 301831 [details] [review]: Just a comment fix, the rest looks good. ::: src/devices/nm-device.c @@ +7991,3 @@ + if (device_has_capability (self, NM_DEVICE_CAP_CARRIER_DETECT)) { + /* We cache the ignore_carrier state to don't react on config-reloads while the connection "to not" or "so that we don't"
Thanks, both patches merged to master: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=9847ab7147465de089b0093ad74bd8b07f5d1b27 (after resolving conflicts while rebasing)