After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748047 - C#: Add support for the "var" keyword
C#: Add support for the "var" keyword
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
unspecified
Other All
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-17 12:39 UTC by Moo
Modified: 2015-04-19 12:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (441 bytes, patch)
2015-04-17 12:39 UTC, Moo
none Details | Review
Add support for new keyword and primitive (999 bytes, patch)
2015-04-19 11:54 UTC, Moo
none Details | Review

Comment 1 Sébastien Wilmet 2015-04-17 18:36:57 UTC
Review of attachment 301827 [details] [review]:

Please provide a patch created with the git format-patch command, this is much easier for us to push the commit (and to already have the commit message, author, etc).

Apart from that, the diff is good.
Comment 2 Moo 2015-04-18 00:18:37 UTC
The diff was generated via GitHub.

Could someone help with the patch?

Also with bug #748048
Comment 3 Sébastien Wilmet 2015-04-18 09:15:04 UTC
You should use git from the command line.

This page can maybe help you:
https://developer.gnome.org/programming-guidelines/stable/version-control.html.en

Or the Pro Git book:
https://progit.org/

And of course the man pages.
Comment 4 Moo 2015-04-19 11:54:17 UTC
Created attachment 301926 [details] [review]
Add support for new keyword and primitive

- Add support for the "var" keyword
- Add support for the "dynamic" primitive
Comment 5 Sébastien Wilmet 2015-04-19 12:00:05 UTC
Thanks!

The commit is pushed to the master branch:
https://git.gnome.org/browse/gtksourceview/commit/?id=ccb9adadab97871371c9d7fa56324802fe6b6351

(I've modified a little the commit message, to have a shorter title.)