After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748021 - video-converter: unused variables n_taps max_taps
video-converter: unused variables n_taps max_taps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-17 05:37 UTC by RaviKiran
Modified: 2015-04-17 18:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove unused variables (2.12 KB, patch)
2015-04-17 05:39 UTC, RaviKiran 		committed Details | Review

Description RaviKiran 2015-04-17 05:37:26 UTC 
In setup_scale(), n_taps, max_taps values retrieved using gst_video_scaler_get_coeff(). However, they are unused.
They can be either removed or used for printing debug messages (like other places)
Comment 1 RaviKiran 2015-04-17 05:39:31 UTC 
Created attachment 301776 [details] [review]
remove unused variables

Patch attached. Please reveiew.
Comment 2 Tim-Philipp Müller 2015-04-17 18:25:39 UTC 
Pushed, thanks for the patch.

commit e78d44ac0bbd6ad5e3d5b2709170e96f14afd893
Author: Ravi Kiran K N <ravi.kiran@samsung.com>
Date:   Fri Apr 17 11:18:22 2015 +0530

    video-converter: Remove unused variables
    
    Remove unused variables n_taps, max_taps in setup_scale()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748021