After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747995 - programming guidelines: a few various improvements
programming guidelines: a few various improvements
Status: RESOLVED FIXED
Product: gnome-devel-docs
Classification: Applications
Component: programming-guidelines
3.16.x
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Devel docs: Programming Guidelines maintainer(s)
gnome-devel-docs maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-16 14:02 UTC by Sébastien Wilmet
Modified: 2015-04-16 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
programming-guidelines: fix some typos (3.60 KB, patch)
2015-04-16 14:03 UTC, Sébastien Wilmet 		committed Details | Review
programming-guidelines: use class instead of object where appropriate (1.64 KB, patch)
2015-04-16 14:03 UTC, Sébastien Wilmet 		committed Details | Review
programming-guidelines: a few more explanation about git (1.76 KB, patch)
2015-04-16 14:03 UTC, Sébastien Wilmet 		committed Details | Review

Description Sébastien Wilmet 2015-04-16 14:02:23 UTC 
See the attached patches.
Comment 1 Sébastien Wilmet 2015-04-16 14:03:04 UTC 
Created attachment 301732 [details] [review]
programming-guidelines: fix some typos
Comment 2 Sébastien Wilmet 2015-04-16 14:03:09 UTC 
Created attachment 301733 [details] [review]
programming-guidelines: use class instead of object where appropriate

For a method: a method is part of a class, not for a specific object.

For headers: a header generally contains a class definition, not an
object.
Comment 3 Sébastien Wilmet 2015-04-16 14:03:19 UTC 
Created attachment 301734 [details] [review]
programming-guidelines: a few more explanation about git

- A beginner might not understand what is a forced push.
- wip stands for work-in-progress.
- explain why we do rebases instead of merging.
- on git.gnome.org: wip/nickname/
Comment 4 Philip Withnall 2015-04-16 14:57:14 UTC 
Review of attachment 301732 [details] [review]:

++
Comment 5 Philip Withnall 2015-04-16 14:59:23 UTC 
Review of attachment 301733 [details] [review]:

I don’t think there’s much point in being particularly anal about this (for example, we deliberately became more relaxed about the OOP terminology used in the patches to update the GObject tutorial — bug #744060), but this is a good patch anyway. Thanks!
Comment 6 Philip Withnall 2015-04-16 15:01:32 UTC 
Review of attachment 301734 [details] [review]:

Looks good to me, thanks.