After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747986 - Improve key-bindings for start-up application tweak
Improve key-bindings for start-up application tweak
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-04-16 11:22 UTC by Phillip Wood
Modified: 2015-04-29 18:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
StartUpTweak: Add a ‘row-activated’ handler (1.36 KB, patch)
2015-04-16 11:23 UTC, Phillip Wood
committed Details | Review
StartupTweak: Add a keybinding to remove an app (1.21 KB, patch)
2015-04-16 11:23 UTC, Phillip Wood
committed Details | Review
StartUpTweak: Add mnemonic to activate ‘+’ button (1.60 KB, patch)
2015-04-16 11:23 UTC, Phillip Wood
committed Details | Review

Description Phillip Wood 2015-04-16 11:22:58 UTC
At the moment adding an application without using the mouse is harder
than it should be.
Comment 1 Phillip Wood 2015-04-16 11:23:03 UTC
Created attachment 301718 [details] [review]
StartUpTweak: Add a ‘row-activated’ handler

Add a ‘row-activated’ handler to the startup group so that the ‘+’
button is activated with the row. Without this the user needs navigate
to the row containing the ‘+’ button and the has to press ‘Tab’ to move
the focus from the list box row to the ‘+’ button before they can
activate it.
Comment 2 Phillip Wood 2015-04-16 11:23:08 UTC
Created attachment 301719 [details] [review]
StartupTweak: Add a keybinding to remove an app

Add bindings for ‘Delete’ and ‘Backspace’ to remove the focused start-up
application.
Comment 3 Phillip Wood 2015-04-16 11:23:13 UTC
Created attachment 301720 [details] [review]
StartUpTweak: Add mnemonic to activate ‘+’ button

Add a mnemonics for ‘+’ and ‘=’ to open the AppChooser dialog.
Comment 4 Rui Matos 2015-04-16 16:42:02 UTC
These don't apply for me, either on their own or on top of bug 747983.
Comment 5 Rui Matos 2015-04-16 16:49:46 UTC
Nevermind, was an issue on my end, they do apply on top of the other patches.
Comment 6 Rui Matos 2015-04-17 14:10:45 UTC
Review of attachment 301718 [details] [review]:

sure
Comment 7 Rui Matos 2015-04-17 14:12:00 UTC
Review of attachment 301719 [details] [review]:

ok
Comment 8 Rui Matos 2015-04-17 14:13:59 UTC
Review of attachment 301720 [details] [review]:

why not?
Comment 9 Phillip Wood 2015-04-29 09:59:17 UTC
Attachment 301718 [details] pushed as d68852b - StartUpTweak: Add a ‘row-activated’ handler
Attachment 301719 [details] pushed as 71d2388 - StartupTweak: Add a keybinding to remove an app
Attachment 301720 [details] pushed as c2fe078 - StartUpTweak: Add mnemonic to activate ‘+’ button

What do you think about backporting
71d2388 - StartupTweak: Add a keybinding to remove an app
c2fe078 - StartUpTweak: Add mnemonic to activate ‘+’ button
to the 3.16 branch?
Comment 10 Rui Matos 2015-04-29 11:13:08 UTC
(In reply to Phillip Wood from comment #9)
> What do you think about backporting
> 71d2388 - StartupTweak: Add a keybinding to remove an app
> c2fe078 - StartUpTweak: Add mnemonic to activate ‘+’ button
> to the 3.16 branch?

Sure, thanks. The row-activated handler can also go in I believe, that signal has been in gtk+ since 3.10
Comment 11 Phillip Wood 2015-04-29 18:12:41 UTC
(In reply to Rui Matos from comment #10)
> (In reply to Phillip Wood from comment #9)
> > What do you think about backporting
> > 71d2388 - StartupTweak: Add a keybinding to remove an app
> > c2fe078 - StartUpTweak: Add mnemonic to activate ‘+’ button
> > to the 3.16 branch?
> 
> Sure, thanks. The row-activated handler can also go in I believe, that
> signal has been in gtk+ since 3.10

I've pushed them all to gnome-3-16