Created attachment 301641 [details] [review]
docs: better documentation for g_file_info_copy_into()

The documentation of g_file_info_copy_into() was misleading. The
attributes are not just copied, @dest_info is also cleared at the
beginning. So any previously set attributes in @dest_info are lost.

There was a bug in gedit about this function, where some metadata were
not saved. So it might make sense to change the implementation to not
clear @dest_info, and copy one by one the attributes from @src_info to
@dest_info.

Created attachment 301642 [details] [review]
docs: improve doc of g_file_info_list_attributes()

The name_space can be NULL.

Created attachment 301643 [details] [review]
docs: GRegex: @start_position is in bytes

The start_position arguments are passed to pcre_exec() as the
startoffset, which is in bytes (not characters).

I had recently a doubt about this, so it's better to document it.

Can someone review the above patches?

Comment on attachment 301642 [details] [review]
docs: improve doc of g_file_info_list_attributes()

Pushed to the master branch since it's a trivial patch and I got no feedbacks after asking one time on IRC and one more time here…

Comment on attachment 301643 [details] [review]
docs: GRegex: @start_position is in bytes

Also pushed, trivial patch.

There is one remaining less trivial patch to review, and which is quite important to avoid bugs in applications…

Review of attachment 301641 [details] [review]:

sure

(In reply to Sébastien Wilmet from comment #5)
> Comment on attachment 301642 [details] [review] [review]
> docs: improve doc of g_file_info_list_attributes()
> 
> Pushed to the master branch since it's a trivial patch and I got no
> feedbacks after asking one time on IRC and one more time here…

Here is some (late) feedback: the subject line would have better talked about annotations, since this is not really about docs.

Attachment 301641 [details] pushed as 95dd373 - docs: better documentation for g_file_info_copy_into()