After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747913 - glmixer: pass the proper free function to frames and buffers array
glmixer: pass the proper free function to frames and buffers array
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-15 13:18 UTC by Guillaume Desmottes
Modified: 2015-04-17 13:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
glmixer: pass the proper free function to frames and buffers array (1.47 KB, patch)
2015-04-15 13:19 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2015-04-15 13:18:41 UTC 
.
Comment 1 Guillaume Desmottes 2015-04-15 13:19:37 UTC 
Created attachment 301626 [details] [review]
glmixer: pass the proper free function to frames and buffers array

'array_buffers' contain borrowed GstBuffer and so shouldn't have a free
function. 'frames' is the one containing GstGLMixerFrameData and so should use
_free_glmixer_frame_data as free function.

Fix GstGLMixerFrameData leaks with the
validate.file.glvideomixer.simple.play_15s.synchronized scenario.

https://bugzilla.gnome.org/show_bug.cgi?id=747913

Signed-off-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Comment 2 Vincent Penquerc'h 2015-04-17 13:34:32 UTC 
commit 481b1c921e9617267eac6ebddfce5d000a0b64c7
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Wed Apr 15 15:16:33 2015 +0200

    glmixer: pass the proper free function to frames and buffers array
    
    'array_buffers' contain borrowed GstBuffer and so shouldn't have a free
    function. 'frames' is the one containing GstGLMixerFrameData and so should use
    _free_glmixer_frame_data as free function.
    
    Fix GstGLMixerFrameData leaks with the
    validate.file.glvideomixer.simple.play_15s.synchronized scenario.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=747913
    
    Signed-off-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>