After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747894 - non-symbolic icon is no longer being installed
non-symbolic icon is no longer being installed
Status: RESOLVED FIXED
Product: lightsoff
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: lightsoff-maint
lightsoff-maint
Depends on:
Blocks:
 
 
Reported: 2015-04-15 08:22 UTC by Dominique Leuenberger
Modified: 2015-04-15 14:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add the symboli icon instead of overwriting the variable (880 bytes, patch)
2015-04-15 08:22 UTC, Dominique Leuenberger 		none Details | Review
Corrected patch - there is a 2nd directory variable being introduced (879 bytes, patch)
2015-04-15 08:25 UTC, Dominique Leuenberger 		committed Details | Review

Description Dominique Leuenberger 2015-04-15 08:22:20 UTC 
https://git.gnome.org/browse/lightsoff/commit/?id=552910757d0718931f44b4c4e184d57ef8122827 introduced a symbolic icon for lightsoff

Due to an error in Makefile.am, though, this resulted in the non-symbolic icon no longer being installed.
Comment 1 Dominique Leuenberger 2015-04-15 08:22:50 UTC 
Created attachment 301596 [details] [review]
Add the symboli icon instead of overwriting the variable
Comment 2 Dominique Leuenberger 2015-04-15 08:25:50 UTC 
Created attachment 301597 [details] [review]
Corrected patch - there is a 2nd directory variable being introduced
Comment 3 Dominique Leuenberger 2015-04-15 09:22:29 UTC 
Due to this typoe, the 3.16.1 tarball is actually broken: only the symbolic icon made it into the tarball (as the variable name for the symbolic icon was wrong)
Comment 4 Michael Catanzaro 2015-04-15 14:09:06 UTC 
Review of attachment 301597 [details] [review]:

Thanks Dominique. We will do a new release.