GNOME Bugzilla – Bug 747856
Export font LCD filter setting
Last modified: 2015-11-03 15:19:55 UTC
I've been missing some settings from xrdb. Patches follow.
Created attachment 301555 [details] [review] xsettings: Export cursor size to X resources
Created attachment 301556 [details] [review] xsettings: Export cursor theme
Created attachment 301557 [details] [review] xsettings: Export font LCD filter setting
(In reply to Jan Alexander Steffens (heftig) from comment #0) > I've been missing some settings from xrdb. Patches follow. Can you explain why you need those, and what might consume them?
The cursor size setting is consumed by Qt4, Qt5 and Tk. Without this setting they use 24x24 cursors. I believe some non-GNOME window managers use the Xcursor.theme setting. The LCD filter setting is consumed by Xft. The LCD filters apply some horizontal blurring in RGBA mode to soften color fringes. When this value isn't set in xrdb or fontconfig it defaults to lcdlegacy, a filter showing more fringing than lcddefault or lcdlight. I pulled the Xft/Lcdfilter xsetting name from some XFCE code; GDK does not support this, so rendering to surfaces other than X pixmaps (where Xft gets used) is currently unaffected by this setting. (I notice that GdkWaylandScreen reads the org.gnome.settings-daemon.plugins.xsettings keys directly.)
Comment on attachment 301555 [details] [review] xsettings: Export cursor size to X resources Attachment 301555 [details] pushed as 5852428 - xsettings: Export cursor size to X resources
Review of attachment 301556 [details] [review]: This needs references added to the patch, pointing to sources where other window managers might be consuming this information.
Review of attachment 301557 [details] [review]: I would only push this if we had GTK+ consuming it, as it has an external API. Please file a bug against GTK+ so that this feature is used (or better, let's choose a better default for current machines).
Created attachment 313106 [details] [review] xsettings: notify on cursor theme changes
This patch is also needed in order to get properly notified of theme changes. In terms of WM using this, I'm not sure about the others, but compiz will use this, so having this upstream will be nice.
Also... libxcursor is expecting cursor theme to be there [1], so I guess it's just fine to have this upstream. [1] http://cgit.freedesktop.org/xorg/lib/libXcursor/tree/src/display.c#n216
Review of attachment 313106 [details] [review]: Given that we haven't merged the cursor theme patch, this is precipitate. Make sure Jan merges that changes in his patch.
Created attachment 313133 [details] [review] xsettings: Export cursor theme Integrated Marco's patch and comments about users of this setting. Thanks.
Review of attachment 313133 [details] [review]: Looks good to me
Comment on attachment 313133 [details] [review] xsettings: Export cursor theme Attachment 313133 [details] pushed as af8a40c - xsettings: Export cursor theme
Review of attachment 301557 [details] [review]: I won't be adding any more Xft related configurations in GNOME. In the long term, we want to use the default fontconfig configuration, which can do per-font configurations, eventually ask information from the toolkit as to whether a particular renderer is available to choose the settings that best match the device. Given that, please discuss the change of default font LCD filtering upstream, with the fontconfig folks. See also: https://bugzilla.gnome.org/show_bug.cgi?id=756204 https://bugzilla.gnome.org/show_bug.cgi?id=757521
Marking as FIXED as the other patches were committed.