GNOME Bugzilla – Bug 747851
core: add nm-plugin-missing property for devices
Last modified: 2015-04-20 08:19:02 UTC
NetworkManager now supports various devices via plugins. If a plugin is not installed, it may not be clear to the user why the device is not working properly. So let's add nm-plugin-missing property for devices and set it to true when the plugin is missing.
Code is in jk/nm-plugin-missing-bgo747851 branch.
this is a helpful feature IMO. missing "Since: 1.2" gtkdoc for nm_device_get_nm_plugin_missing() and PROP_NM_PLUGIN_MISSING (and possibly others?).
(In reply to Thomas Haller from comment #2) > this is a helpful feature IMO. > > missing "Since: 1.2" gtkdoc for nm_device_get_nm_plugin_missing() and > PROP_NM_PLUGIN_MISSING (and possibly others?). Fixed.
> device: add nm-plugin-missing property indicating NM device plugin not available nm-device-private.h is really only supposed to be used by nm-device-*.c, so I'd put nm_device_set_nm_plugin_missing() into nm-device.h instead. Rest looks fine.
(In reply to Dan Williams from comment #4) > > device: add nm-plugin-missing property indicating NM device plugin not available > > nm-device-private.h is really only supposed to be used by nm-device-*.c, so > I'd put nm_device_set_nm_plugin_missing() into nm-device.h instead. > Fixed. Pushed to master: 80a72a4 merge: add new nm-plugin-missing property for devices (bgo #747851) 1b9c1ed cli: add NM-PLUGIN-MISSING to devices 560e195 core: set nm-plugin-missing device property 4c398ab libnm: add nm-plugin-missing property indicating NM device plugin not available fc6373b device: add nm-plugin-missing property indicating NM device plugin not available 823df33 cli: better indicate when a Wi-Fi plugin might not be available (rh #1168573)