After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747844 - RFE: Add support to gdk_keymap_get_scroll_lock_state()
RFE: Add support to gdk_keymap_get_scroll_lock_state()
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-04-14 11:32 UTC by Fabiano Fidêncio
Modified: 2015-04-28 12:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdkkeys: Add support to _get_scroll_lock_state() (14.01 KB, patch)
2015-04-14 11:32 UTC, Fabiano Fidêncio 		committed Details | Review

Description Fabiano Fidêncio 2015-04-14 11:32:18 UTC 
Created attachment 301527 [details] [review]
gdkkeys: Add support to _get_scroll_lock_state()

I know it's a quite theoretical patch beause scroll_lock is not used on (X/Wayland/Linux in general), but I don't think it would harm to have it there and would help on Windows (at least).

The motivation for this is to simplify this current code we have on spice-gtk[0] in a way it could be used without any kind of platform/backend checking.

[0]: http://cgit.freedesktop.org/spice/spice-gtk/tree/gtk/spice-gtk-session.c#n122
Comment 1 Matthias Clasen 2015-04-27 11:48:55 UTC 
Review of attachment 301527 [details] [review]:

ok
Comment 2 Fabiano Fidêncio 2015-04-27 23:10:06 UTC 
Pushed as: aa269d9..fea2e7b