After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747815 - Update DLNA version when protocolInfo exceeds 256 bytes
Update DLNA version when protocolInfo exceeds 256 bytes
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: librygel-core
git master
Other Windows
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2015-04-14 03:28 UTC by Parthiban Balasubramanian
Modified: 2015-07-05 20:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
DLNA Version Patch (2.16 KB, patch)
2015-04-14 03:28 UTC, Parthiban Balasubramanian
committed Details | Review

Description Parthiban Balasubramanian 2015-04-14 03:28:06 UTC
Created attachment 301502 [details] [review]
DLNA Version Patch

There are situations when most of the time with the CVP2 server, when it exposes support for playspeeds,etc and it exceeds 256 bytes in the protocolInfo. DLNA CTT also fails DSM if the protocolInfo exceeds 256 bytes and the version is not v1.51

As per Errata 00223v006, if the protocolInfo string has a case of exceeding 256 bytes then the DLNA version must be 1.51
Comment 1 Jens Georg 2015-04-14 07:42:43 UTC
Review of attachment 301502 [details] [review]:

That's not "changing the DLNA version when protocolInfo string exceeds 256bytes" Thats "changing the DLNA version". What other implications does an announcement of DLNA v1.51 have?
Comment 2 Parthiban Balasubramanian 2015-04-15 02:43:09 UTC
As per the latest DLNA spec released on March 2014, there is only 3 places where specific mention about what to do about 1.51 vs 1.50

(1) If the Server response has more than 256 bytes then the version  of DLNA must be 1.51
(2) Control Points implementing the latest spec must expose DLNA v1.51 & dlna:X_DLNADOC must be exposing the device as DLNA v1.51 compatible.
(3) If the Server is responding is v1.51 and the client is 1.50, then DMS has to strip the protocolInfo to fit only 256 bytes.

With this patch it will cover Item (1) and (2).

Item (3) has not been working even with 1.50 also(So there is no regressions by changing the DLNA version. I have run many CTT to make sure there is no issue with the version change.)

Let me know if you have any questions.
Comment 3 Jens Georg 2015-04-15 07:16:07 UTC
Have you tested running a 1.51 dms against common 1.5 DMP/DMC/DMR? Does it still work?

I'm not sure most devices in the wild currently know that there is something like DLNA 1.51 and given the previous experiences with "should be compatible with newer versions" I'm very much afraid that bumping the DLNA version will kill interoperability with plenty of devices.
Comment 4 Parthiban Balasubramanian 2015-05-04 14:35:25 UTC
Yes we have been testing against DMR with 1.5. Our DMS was also 1.5 until we hit the issue of sending protocolInfo more thatn 256 bytes and CTT failed on us a few months back.There seems no difference using 1.50 vs 1.51 except we can send more info in protocolInfo.
Bumping the version did not choke the DMRs.
Comment 5 Jens Georg 2015-06-11 14:29:24 UTC
Ok. I'll do a check with my devices as well and if that works, I think we can release it.