After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747812 - unset LDFLAGS when unsetting CFLAGS
unset LDFLAGS when unsetting CFLAGS
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Build system
2.6.6
Other Linux
: Normal normal
: ---
Assigned To: gnucash-core-maint
gnucash-core-maint
Depends on:
Blocks:
 
 
Reported: 2015-04-14 00:39 UTC by Bill Nottingam
Modified: 2018-06-29 23:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix build in certain circumstances (652 bytes, patch)
2015-04-14 00:39 UTC, Bill Nottingam 		committed Details | Review

Description Bill Nottingam 2015-04-14 00:39:25 UTC 
Created attachment 301498 [details] [review]
Fix build in certain circumstances

If you're using odd CFLAGS & LDFLAGS, unsetting one without the other can cause a configure failure.

Patch attached.
Comment 1 Bill Nottingam 2015-04-17 20:10:15 UTC 
Just for more information - the case I noted where this is needed to fix the build is in Fedora 23 or later, where the default LDFLAGS are set to make position-independent executables, which then rely on the CFLAGS that set -fPIC.
Comment 2 John Ralls 2015-04-17 21:17:09 UTC 
OK, but the place that your patch clears the LDFLAGS is around AC_CHECK_HEADERS, which isn't supposed to link. The patch is harmless, of course, but it should be a no-op. Can you investigate to find out why it isn't?
Comment 3 Bill Nottingam 2015-04-17 23:19:36 UTC 
It should be around AC_CHECK_FUNCS, which does link. I'll double-check that the patch got generated right.
Comment 4 Bill Nottingam 2015-04-19 18:01:31 UTC 
The patch looks correct to me - unsetting before AC_CHECK_FUNCS, restoring afterwards.
Comment 5 John Ralls 2015-04-25 23:39:16 UTC 
Comment on attachment 301498 [details] [review]
Fix build in certain circumstances

OK, I see where my brain failed. Committed and pushed to maint; it will bubble up to master in a few days.

Thanks!
Comment 6 John Ralls 2018-06-29 23:40:16 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=747812. Please update any external references or bookmarks.