After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747705 - OpenCV plugin uses legacy OpenCV-1-style headers
OpenCV plugin uses legacy OpenCV-1-style headers
Status: RESOLVED DUPLICATE of bug 725163
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-11 17:00 UTC by LRN
Modified: 2015-04-17 16:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Change opencv plugin to use opencv2-style includes (16.73 KB, patch)
2015-04-11 17:00 UTC, LRN
committed Details | Review

Description LRN 2015-04-11 17:00:04 UTC
This works OK even with OpenCV2 only because OpenCV2 normally installs
a legacy compat headers. But package maintainer is not obligated to pack these,
(as far as i know, Debian indeed does not, for example). Since OpenCV plugin
depends on OpenCV 2.x anyway, why not save everyone the trouble and just make
it use OpenCV2 headers directly?
Comment 1 LRN 2015-04-11 17:00:11 UTC
Created attachment 301370 [details] [review]
Change opencv plugin to use opencv2-style includes

If old opencv1-style legacy include directory is available,
this change becomes purely cosmetic (maybe will compile a bit faster).
It becomes an FTBFS fix when opencv1-style include directory is missing
(possibly because opencv package maintainer decided not to pack it).
Comment 2 LRN 2015-04-11 19:22:01 UTC

*** This bug has been marked as a duplicate of bug 725163 ***
Comment 3 Sebastian Dröge (slomo) 2015-04-17 16:32:42 UTC
Comment on attachment 301370 [details] [review]
Change opencv plugin to use opencv2-style includes

commit 589407a077fb645d805b86494d9d7fc56a104a64
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Sat Apr 11 16:53:38 2015 +0000

    opencv: Change opencv plugin to use opencv2-style includes
    
    If old opencv1-style legacy include directory is available,
    this change becomes purely cosmetic (maybe will compile a bit faster).
    It becomes an FTBFS fix when opencv1-style include directory is missing
    (possibly because opencv package maintainer decided not to pack it).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=747705