After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747631 - Simplify UI codes
Simplify UI codes
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-10 15:13 UTC by Trinh Anh Ngoc
Modified: 2015-04-12 08:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Simplify UI codes (6.82 KB, patch)
2015-04-10 15:13 UTC, Trinh Anh Ngoc 		committed Details | Review

Description Trinh Anh Ngoc 2015-04-10 15:13:23 UTC 
Created attachment 301297 [details] [review]
Simplify UI codes

Simplify codes that i made in https://bugzilla.gnome.org/show_bug.cgi?id=739836.
Comment 1 Carlos Garcia Campos 2015-04-10 16:06:47 UTC 
Could you explain a bit more the reasoning or provide screenshots with the differences?
Comment 2 Trinh Anh Ngoc 2015-04-10 17:32:03 UTC 
No UI difference. In my previous patches, i used 4 LOC to set margins (should set border-width instead). Also, remove gtk_scrolled_window_set_shadow_type instead of using css to remove it => reduce LOC.
Comment 3 Carlos Garcia Campos 2015-04-12 08:27:49 UTC 
Comment on attachment 301297 [details] [review]
Simplify UI codes

Ok, pushed explaining the change and clarifying things in the commit message. Thanks