After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747583 - New game: Wall
New game: Wall
Status: RESOLVED FIXED
Product: aisleriot
Classification: Other
Component: games
git master
Other Linux
: Normal enhancement
: ---
Assigned To: aisleriot-maint
aisleriot-maint
Depends on:
Blocks:
 
 
Reported: 2015-04-09 19:38 UTC by Otto Wallenius
Modified: 2015-06-09 16:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
New game Wall for Aisleriot (24.43 KB, patch)
2015-04-09 19:38 UTC, Otto Wallenius
none Details | Review
New game Wall for Aisleriot - Updated (25.32 KB, patch)
2015-04-25 12:35 UTC, Otto Wallenius
accepted-commit_now Details | Review

Description Otto Wallenius 2015-04-09 19:38:47 UTC
Created attachment 301235 [details] [review]
New game Wall for Aisleriot

This is a game that me and my two friends came up with. The game uses a double deck. 45 cards are dealt on the table in a wall formation. Above the wall are 'guard post' piles and a pile with two kings. The player attacks first the wall, then the guard posts and finally the kings with the remaining cards. The game is won if the player is able to beat the two kings at the top before he or she runs out of attack cards. An attack succeeds if the sum of values of the attack cards is higher than the 'health' of the cards under attack. Health is also computed as a certain sum of card values. Detailed rules are in the attached patch in help/C/wall.xml .

The patch can be applied against the current head at github master branch, ebace20fa7.
Comment 1 Vincent Povirk 2015-04-19 16:57:25 UTC
Hi, thanks for the patch. Looks pretty solid overall, I just have some minor comments.

The hint function will tell you whether you can attack a face-down slot and win, and the value of its top card. In a future version of Aisleriot, hints may be changed to have a visual indicator of the slots involved, and if so this would also reveal which face-down slot can be successfully attacked.

I'd probably change find-winnable-slot to only account for face-up slots, and have a separate type of hint that advises attacking face-down slots unconditionally.

(droppable?) should return false when start-slot and end-slot are equal, to avoid creating an empty undo entry.

Do the kings have to be evil? I don't feel like it's necessary for the game's narrative to judge the morality of the player's actions.

GNOME seems to recommend avoiding personal pronouns in documentation other than "you". Maybe references to "the player" in documentation should be replaced with "you"? Just mentioning this because gendered language is something I've become sensitive to recently, not trying to nit-pick your writing style. I wouldn't be surprised if we do the same thing in existing documentation, including things I've written, as I didn't really think about it until now. https://developer.gnome.org/gdp-style-guide/2.32/gdp-style-guide.html#locale-5
Comment 2 Otto Wallenius 2015-04-25 12:35:45 UTC
Created attachment 302332 [details] [review]
New game Wall for Aisleriot - Updated
Comment 3 Otto Wallenius 2015-04-25 12:36:29 UTC
Thanks a lot for the corrections and suggestions. I think they were all good and I fixed the problems as you suggested.

I also made another minor change: even if you can't remove any visible cards (so you also can't win), the game won't end if you can still attack a face-down slot. This makes sense since you can potentially increase the score by attacking that slot, and furthermore, in every other situation as well the game continues until there are no possible moves.

I attached an updated patch.
Comment 4 Vincent Povirk 2015-04-26 18:47:15 UTC
Looks good to me.
Comment 5 Otto Wallenius 2015-04-27 17:15:58 UTC
Could someone commit this for me? I don't have commit access.
Comment 6 Christian Persch 2015-06-09 16:08:16 UTC
Pushed to master.