After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747565 - No appdata screenshots
No appdata screenshots
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: books
3.16.x
Other All
: Normal normal
: ---
Assigned To: GNOME Books Maintainers
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-04-09 14:39 UTC by Andreas Nilsson
Modified: 2015-12-08 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot 1 (530.19 KB, image/png)
2015-04-09 14:42 UTC, Andreas Nilsson
  Details
screenshot 2 (521.84 KB, image/png)
2015-04-09 14:43 UTC, Andreas Nilsson
  Details
screenshot 3 (390.72 KB, image/png)
2015-04-09 14:43 UTC, Andreas Nilsson
  Details
Add GNOME Books screenshot (668.41 KB, patch)
2015-08-17 22:49 UTC, Alessandro Bono
none Details | Review
Add GNOME Books screenshots (1.14 MB, patch)
2015-08-17 22:50 UTC, Alessandro Bono
none Details | Review
screenshot 1 v2 (754.00 KB, image/png)
2015-08-31 10:46 UTC, Andreas Nilsson
  Details
screenshot 2 v2 (634.84 KB, image/png)
2015-08-31 10:47 UTC, Andreas Nilsson
  Details
screenshot 3 v2 (845.06 KB, image/png)
2015-08-31 10:47 UTC, Andreas Nilsson
  Details
Add GNOME Books screenshot (963.62 KB, patch)
2015-08-31 11:11 UTC, Alessandro Bono
committed Details | Review
Add GNOME Books screenshot 2 (806.69 KB, patch)
2015-08-31 11:22 UTC, Alessandro Bono
committed Details | Review
Add GNOME Books screenshot 3 (1.06 MB, patch)
2015-08-31 11:22 UTC, Alessandro Bono
committed Details | Review
appdata: Add screenshots for Books (1.19 KB, patch)
2015-12-08 16:47 UTC, Debarshi Ray
committed Details | Review

Description Andreas Nilsson 2015-04-09 14:39:23 UTC
There are no screenshots for GNOME Books in GNOME Software.
Comment 1 Andreas Nilsson 2015-04-09 14:42:52 UTC
Created attachment 301211 [details]
screenshot 1
Comment 2 Andreas Nilsson 2015-04-09 14:43:10 UTC
Created attachment 301212 [details]
screenshot 2
Comment 3 Andreas Nilsson 2015-04-09 14:43:32 UTC
Created attachment 301213 [details]
screenshot 3
Comment 4 Alessandro Bono 2015-08-17 22:29:18 UTC
Thanks for the screenshots, they look really good!

I have some doubts about the AppData specification[1]. It says that the screenshot should contains only the window (and a 16:9 aspect ratio), but the attached screenshots contain also the gnome-shell top bar.

I'll attach a patch with these screenshots, but maybe we should consider to follow strictly the specification. Since your application content is really nice, could you take some new screenshots without the gnome-shell top bar? This tool[2] is intended to make the application sized with a 16:9 aspect ratio and you can use Alt+Print to take a screenshot of the window.

[1] https://secure.freedesktop.org/~hughsient/appdata/#screenshots
[2] https://blogs.gnome.org/hughsie/2013/10/08/how-to-take-169-screenshots/
Comment 5 Alessandro Bono 2015-08-17 22:49:34 UTC
Created attachment 309428 [details] [review]
Add GNOME Books screenshot
Comment 6 Alessandro Bono 2015-08-17 22:50:06 UTC
Created attachment 309429 [details] [review]
Add GNOME Books screenshots
Comment 7 Alessandro Bono 2015-08-27 11:51:31 UTC
I talked with Richard Hughes (the person who coordinates this effort) and he said: "we really don't want the top bar in the screenshot".
Could you attach some screenshots without the gnome-shell top bar?
Comment 8 Andreas Nilsson 2015-08-31 10:46:42 UTC
Created attachment 310339 [details]
screenshot 1 v2
Comment 9 Andreas Nilsson 2015-08-31 10:47:04 UTC
Created attachment 310340 [details]
screenshot 2 v2
Comment 10 Andreas Nilsson 2015-08-31 10:47:24 UTC
Created attachment 310341 [details]
screenshot 3 v2
Comment 11 Andreas Nilsson 2015-08-31 10:47:43 UTC
Hope these works better.
Comment 12 Alessandro Bono 2015-08-31 11:11:33 UTC
Created attachment 310343 [details] [review]
Add GNOME Books screenshot
Comment 13 Alessandro Bono 2015-08-31 11:22:18 UTC
Created attachment 310345 [details] [review]
Add GNOME Books screenshot 2
Comment 14 Alessandro Bono 2015-08-31 11:22:50 UTC
Created attachment 310346 [details] [review]
Add GNOME Books screenshot 3
Comment 15 Richard Hughes 2015-09-18 13:33:42 UTC
New screenshots look much better; thanks.
Comment 16 Debarshi Ray 2015-12-08 16:46:37 UTC
Splinter can't handle those PNG-loaded patches. :)

Anyway, I have pushed them to master now. Thanks!
Comment 17 Debarshi Ray 2015-12-08 16:47:30 UTC
Created attachment 316956 [details] [review]
appdata: Add screenshots for Books

Just having the PNG files is not enough. We need to add them to the appdata file too.
Comment 18 Bastien Nocera 2015-12-08 16:49:44 UTC
(In reply to Debarshi Ray from comment #17)
> Created attachment 316956 [details] [review] [review]
> appdata: Add screenshots for Books
> 
> Just having the PNG files is not enough. We need to add them to the appdata
> file too.

Which I've done in master. I also added the downstream gnome-documents screenshots there.