After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747539 - popover: Remove signal handlers in dispose
popover: Remove signal handlers in dispose
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-04-09 00:21 UTC by Matthias Clasen
Modified: 2015-04-09 10:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
popover: Remove signal handlers in dispose (999 bytes, patch)
2015-04-09 00:22 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2015-04-09 00:21:58 UTC 
If we don't, they may get triggered at an inopportune
time later, causing us to crash.

See
https://bugzilla.redhat.com/show_bug.cgi?id=1203499
Comment 1 Matthias Clasen 2015-04-09 00:22:01 UTC 
Created attachment 301167 [details] [review]
popover: Remove signal handlers in dispose
Comment 2 Carlos Garnacho 2015-04-09 10:38:30 UTC 
Comment on attachment 301167 [details] [review]
popover: Remove signal handlers in dispose

Looks good to me, it's indeed icky to try to gtk_popover_apply_modality(popover, FALSE) at this time...
Comment 3 Matthias Clasen 2015-04-09 10:39:25 UTC 
Attachment 301167 [details] pushed as ac931e9 - popover: Remove signal handlers in dispose