After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747498 - subparse : need_segment flag was set too early
subparse : need_segment flag was set too early
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.4.5
Other Windows
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 661726 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-04-08 10:10 UTC by Mingke Wang
Modified: 2018-11-03 11:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
set need_segment after sink pad received GST_EVENT_SEGMENT (2.59 KB, patch)
2015-04-08 10:10 UTC, Mingke Wang
none Details | Review
subparse: set need_segment after sink pad received GST_EVENT_SEGMENT (2.24 KB, patch)
2018-05-19 09:12 UTC, Edward Hervey
none Details | Review

Description Mingke Wang 2015-04-08 10:10:05 UTC
Created attachment 301118 [details] [review]
set need_segment after sink pad received  GST_EVENT_SEGMENT

subparse works in push mode, chain funciton will be called once up stream element finished the seeking and flushing. if set need_segment flag in src pad event handler, the segment event will be pushed earlier, result in the subtitle text will
be send out to down stream from the beginning. if the text sink (such as using appsink to catch text) don't compare the video timestamp with the received text timestamp, then the text and video will not sync.
Comment 1 Tim-Philipp Müller 2016-04-18 14:37:00 UTC
*** Bug 661726 has been marked as a duplicate of this bug. ***
Comment 2 Edward Hervey 2018-05-19 09:12:32 UTC
Created attachment 372211 [details] [review]
subparse: set need_segment after sink pad received GST_EVENT_SEGMENT

subparse works in push mode, chain funciton will be called once
up stream element finished the seeking and flushing.
if set need_segment flag in src pad event handler, the segment
event will be pushed earlier, result in the subtitle text will
be send out to down stream from the beginning.

Upstream Status: Inappropriate [i.MX specific]

Signed-off-by: Mingke Wang <mingke.wang@freescale.com>
Comment 3 Edward Hervey 2018-05-19 09:13:20 UTC
Updated the patch against current master. Can someone knowledgeable about subparse check it ?
Comment 4 Tim-Philipp Müller 2018-05-19 09:25:59 UTC
I don't really understand what this is trying to fix.

What happens without the patch in what scenario, and what happens with the patch in the same scenario?
Comment 5 GStreamer system administrator 2018-11-03 11:36:44 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/179.