After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747494 - sink: fixed applying crop when vaapisink attached to existing X window
sink: fixed applying crop when vaapisink attached to existing X window
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
unspecified
Other All
: Low minor
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-08 09:39 UTC by Víctor Manuel Jáquez Leal
Modified: 2016-11-04 17:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sink: fixed applying crop when vaapisink attached to existing X window (4.86 KB, patch)
2015-04-08 09:39 UTC, Víctor Manuel Jáquez Leal 		none Details | Review

Description Víctor Manuel Jáquez Leal 2015-04-08 09:39:43 UTC 
The opened merge-requests in gitorious have gone bitrotten. Now that gstreamer-vaapi
has move to github, I'm moving those merge-requests into a bug reports in bugzilla.
Comment 1 Víctor Manuel Jáquez Leal 2015-04-08 09:39:46 UTC 
Created attachment 301109 [details] [review]
sink: fixed applying crop when vaapisink attached to existing X window

This was causing issues when playing back 1080 video as source when
sink attached to an existing x window. It was creating black borders
on the left and right of the video as it was setting the
sink->display_rect based on video size (1920x1088) rather than the
requested crop size (1920x1080).
Comment 2 Víctor Manuel Jáquez Leal 2015-04-08 09:44:51 UTC 
Personally, I don't think this patch is correct.
Comment 3 sreerenj 2016-03-24 16:54:36 UTC 
Moving to Product:GStreamer, Component:gstreamer-vaapi
Comment 4 Víctor Manuel Jáquez Leal 2016-11-04 17:10:07 UTC 
Since the differentiation of allocation caps and negotiation caps, this patch is not required anymore. Hence closing as already fixed.