After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747438 - doc: bufferlist: Update document for return value of gst_buffer_list_get
doc: bufferlist: Update document for return value of gst_buffer_list_get
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-07 08:57 UTC by Prashant Gotarne
Modified: 2015-04-08 08:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
doc: bufferlist: Updated document for return value of gst_buffer_list_get (1.01 KB, patch)
2015-04-07 08:59 UTC, Prashant Gotarne
committed Details | Review

Description Prashant Gotarne 2015-04-07 08:57:12 UTC
Return buffer become invalid if it got removed from list using call 
gst_buffer_list_remove or gst_buffer_list_foreach.

As per the documentation the return value is valid as long as @list is valid.
But in case of modification of list using gst_buffer_list_remove or gst_buffer_list_foreach function, @list is still valid but return buffer become invalid if it got removed.
Comment 1 Prashant Gotarne 2015-04-07 08:59:04 UTC
Created attachment 301049 [details] [review]
doc: bufferlist: Updated document for return value of gst_buffer_list_get

Return buffer remains valid as long as list is valid 
and buffer is not removed from list.
Comment 2 Tim-Philipp Müller 2015-04-08 08:46:48 UTC
This seems common sense to me, not sure it needs to be explicitly documented, but why not:

commit c547e010187efde0615d625339936466def84282
Author: Prashant Gotarne <ps.gotarne@samsung.com>
Date:   Tue Apr 7 14:34:58 2015 +0530

    bufferlist: minor docs addition for gst_buffer_list_get()
    
    Return buffer remains valid as long as list is valid
    and buffer is not removed from list.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=747438
Comment 3 Tim-Philipp Müller 2015-04-08 08:47:14 UTC
Comment on attachment 301049 [details] [review]
doc: bufferlist: Updated document for return value of gst_buffer_list_get

Committed with form->from