After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747375 - Fix a wrong header guard in libempathy-gtk/empathy-smiley-manager.h
Fix a wrong header guard in libempathy-gtk/empathy-smiley-manager.h
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2015-04-05 15:51 UTC by Ting-Wei Lan
Modified: 2015-04-07 15:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
trivial: Fix a wrong header guard (829 bytes, patch)
2015-04-05 15:51 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2015-04-05 15:51:06 UTC 
In libempathy-gtk/empathy-smiley-manager.h:

#ifndef __EMPATHY_SMILEY_MANAGER__H__
#define __EMPATHY_SMILEY_MANAGER_H__


The #ifndef uses a wrong macro name. This bug is found by clang.
Comment 1 Ting-Wei Lan 2015-04-05 15:51:56 UTC 
Created attachment 300989 [details] [review]
trivial: Fix a wrong header guard
Comment 2 Debarshi Ray 2015-04-07 15:15:11 UTC 
Review of attachment 300989 [details] [review]:

Looks good to me. xclaesse, cassidy?
Comment 3 Debarshi Ray 2015-04-07 15:30:08 UTC 
Review of attachment 300989 [details] [review]:

From #empathy on GIMPNet:

15:15 <rishi> xclaesse: cassidy: Did you notice this build fix:                
      https://bugzilla.gnome.org/show_bug.cgi?id=747375 ?
15:27 <xclaesse> rishi, +1 to merge it :)
Comment 4 Ting-Wei Lan 2015-04-07 15:40:48 UTC 
Attachment 300989 [details] pushed as 7567d73 - trivial: Fix a wrong header guard