After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747368 - Some file are installed at wrong directories
Some file are installed at wrong directories
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: build
0.22.x
Other Linux
: Normal major
: 0.24
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-05 11:41 UTC by Joerg C. Frings-Fuerst
Modified: 2016-07-20 19:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
transitions: Load icon from resource (5.93 KB, patch)
2016-07-20 19:03 UTC, Jens Georg 		committed Details | Review
import: Load icon from resource (3.31 KB, patch)
2016-07-20 19:03 UTC, Jens Georg 		committed Details | Review
publish: Load resources from GResource (11.60 KB, patch)
2016-07-20 19:04 UTC, Jens Georg 		committed Details | Review
publishing-extra: Load resources from GResource (10.49 KB, patch)
2016-07-20 19:04 UTC, Jens Georg 		committed Details | Review

Description Joerg C. Frings-Fuerst 2015-04-05 11:41:38 UTC 
Hi,

at debian i get the lintian message:

W: shotwell: image-file-in-usr-lib usr/lib/shotwell/plugins/builtin/f-spot-24.png
N: 
N:    This package installs a pixmap or a bitmap within /usr/lib. According to
N:    the Filesystem Hierarchy Standard, architecture-independent files need
N:    to be placed within /usr/share instead.
N:    
N:    Severity: normal, Certainty: certain
N:    
N:    Check: files, Type: binary, udeb
N: 
W: shotwell: image-file-in-usr-lib usr/lib/shotwell/plugins/builtin/facebook.png
W: shotwell: image-file-in-usr-lib usr/lib/shotwell/plugins/builtin/flickr.png
W: shotwell: image-file-in-usr-lib usr/lib/shotwell/plugins/builtin/gallery3.png
[...]

Can you place them at /usr/share/...

CU
Jörg
Comment 1 Joerg C. Frings-Fuerst 2015-04-05 11:47:51 UTC 
change component to build
Comment 2 Jens Georg 2016-04-23 20:27:06 UTC 
Ah, that's the plugin-related files. not sure why they go into lib.
Comment 3 Jens Georg 2016-06-30 20:56:25 UTC 
That is a slightly bigger change as the code expects the data to live next to the plugin to support running in-tree.
Comment 4 Jens Georg 2016-07-20 19:03:51 UTC 
Created attachment 331836 [details] [review]
transitions: Load icon from resource

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 5 Jens Georg 2016-07-20 19:03:58 UTC 
Created attachment 331837 [details] [review]
import: Load icon from resource

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 6 Jens Georg 2016-07-20 19:04:02 UTC 
Created attachment 331838 [details] [review]
publish: Load resources from GResource

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 7 Jens Georg 2016-07-20 19:04:09 UTC 
Created attachment 331839 [details] [review]
publishing-extra: Load resources from GResource

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 8 Jens Georg 2016-07-20 19:04:29 UTC 
Attachment 331836 [details] pushed as 92e38a3 - transitions: Load icon from resource
Attachment 331837 [details] pushed as 23ad562 - import: Load icon from resource
Attachment 331838 [details] pushed as 8f86cda - publish: Load resources from GResource
Attachment 331839 [details] pushed as 83e2e81 - publishing-extra: Load resources from GResource