GNOME Bugzilla – Bug 747364
Fix GError leak in g_file_query_writable_namespaces()
Last modified: 2015-08-21 04:45:18 UTC
gvfs commit b358ca "Make sure metadata is always returned by query_writable_namespaces()" changed the query_writable_namespaces vfunc to never return NULL, but the error checking in g_daemon_file_query_writable_namespaces still assumes vfunc failure implies NULL return value and GError set. This causes a memory leak as on failure the GError will be set but the vfunc implementation will have created its own default list so NULL will not be returned, and the GError will never be cleared. This commit directly checks if the GError is set to detect failures, my_error is directly dereferenced in the error block anyway. This also removes an unneeded call to g_file_attribute_info_new(); as the vfunc always returns us a non-NULL GFileAttributeInfoList.
Created attachment 300980 [details] [review] Fix GError leak in g_file_query_writable_namespaces()
Attachment 300980 [details] pushed as 60a6ae6 - Fix GError leak in g_file_query_writable_namespaces()