After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747360 - Return proper type from g_daemon_file_monitor_{dir,file}
Return proper type from g_daemon_file_monitor_{dir,file}
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2015-04-05 09:35 UTC by Christophe Fergeau
Modified: 2015-04-10 08:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Return proper type from g_daemon_file_monitor_{dir,file} (1.14 KB, patch)
2015-04-05 09:35 UTC, Christophe Fergeau 		accepted-commit_now Details | Review

Description Christophe Fergeau 2015-04-05 09:35:03 UTC 
These functions return pointers, so it's better to return NULL rather
than FALSE.
Comment 1 Christophe Fergeau 2015-04-05 09:35:07 UTC 
Created attachment 300974 [details] [review]
Return proper type from g_daemon_file_monitor_{dir,file}
Comment 2 Ross Lagerwall 2015-04-05 12:23:15 UTC 
Review of attachment 300974 [details] [review]:

Looks good.
Comment 3 Christophe Fergeau 2015-04-10 08:33:34 UTC 
Attachment 300974 [details] pushed as ee43020 - Return proper type from g_daemon_file_monitor_{dir,file}