GNOME Bugzilla – Bug 747293
audiodecoder: Add sink and src query virtual method
Last modified: 2015-04-23 18:47:28 UTC
I just add sink_query() / src_query() virtual method for audio decoder. I thought implementing some custom query for omx audio decoders, it can make it easy to handle queries.
Created attachment 300876 [details] [review] audiodecoder: Add sink and src query virtual method
Comment on attachment 300876 [details] [review] audiodecoder: Add sink and src query virtual method >- if (!(res = gst_audio_encoded_audio_convert (&dec->priv->ctx.info, >+ if (!(res = gst_audio_encoded_audio_convert (&decoder->priv->ctx.info, It looks like your patch is larger than necessary because you chose to call the decoder variable 'decoder' instead of 'dec' in the query_default function, which necessitates unrelated changes. Please rename it to 'dec' in order to minimise the diff.
Created attachment 300881 [details] [review] audiodecoder: Add sink and src query virtual method I changed the name of decoder variable 'decoder' to 'dec'. Thank you.
Thanks, pushed with minor cosmetic changes (used pad as object for debug logging in some places; use GST_OBJECT_CAST instead of GST_OBJECT when calling pad default function; header indentation; moved one comment back to where it was originally; added 'Since 1.6' to gtk-doc comment): commit 5dffb8a3117ba08f0a10b0f3949b6d178a468668 Author: Wonchul Lee <chul0812@gmail.com> Date: Fri Apr 3 00:44:12 2015 +0900 audiodecoder: Add sink and src query virtual method API: GstAudioDecoderClass::src_query() API: GstAudioDecoderClass::sink_query() https://bugzilla.gnome.org/show_bug.cgi?id=747293