After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747288 - [HighContrast] Insensitive backdrop ListBoxRow have an unnecessary border
[HighContrast] Insensitive backdrop ListBoxRow have an unnecessary border
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-04-03 08:00 UTC by Arnaud B.
Modified: 2015-04-10 14:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot. (930.28 KB, image/png)
2015-04-03 08:00 UTC, Arnaud B.
  Details
HighContrast: insensitive backdrop list rows have a border (10.14 KB, patch)
2015-04-10 13:13 UTC, Jakub Steiner
none Details | Review
HighContrast: insensitive backdrop list rows have a border (11.43 KB, patch)
2015-04-10 14:18 UTC, Jakub Steiner
none Details | Review
HighContrast: insensitive backdrop list rows have a border (12.85 KB, patch)
2015-04-10 14:53 UTC, Jakub Steiner
committed Details | Review

Description Arnaud B. 2015-04-03 08:00:15 UTC
Created attachment 300868 [details]
Screenshot.

When using the HighContrast theme, insensitive GtkListBoxRows that are in backdrop state present a big border, that shouldn’t be displayed.
Comment 1 Jakub Steiner 2015-04-10 13:13:57 UTC
Created attachment 301283 [details] [review]
HighContrast: insensitive backdrop list rows have a border
Comment 2 Jakub Steiner 2015-04-10 13:14:08 UTC
I tried syncing list-rows with Adwaita and the border seems to come from list-row.button:backdrop:insensitive, however there seems to be some extra padding coming from something else as well. Any idea, Lapo?
Comment 3 Jakub Steiner 2015-04-10 14:18:17 UTC
Created attachment 301290 [details] [review]
HighContrast: insensitive backdrop list rows have a border
Comment 4 Lapo Calamandrei 2015-04-10 14:41:05 UTC
we're not anal enough about resetting the border-style in .list-row.button section, and we get overridden by .button:insensitive:backdrop. Lemme fix that in adwaita and cherry pick.
Comment 5 Lapo Calamandrei 2015-04-10 14:47:54 UTC
This is totally Matthias fault though, since there isn't an insensitive list-row in the widget factory! ;-)
Comment 6 Jakub Steiner 2015-04-10 14:53:53 UTC
Created attachment 301294 [details] [review]
HighContrast: insensitive backdrop list rows have a border
Comment 7 Jakub Steiner 2015-04-10 14:58:34 UTC
Attachment 301294 [details] pushed as 26e8037 - HighContrast: insensitive backdrop list rows have a border