After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747221 - gvfs-hal-volume-monitor memory issue
gvfs-hal-volume-monitor memory issue
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: [obsolete] hal volume monitor
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2015-04-02 03:33 UTC by David Liang
Modified: 2015-04-02 11:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
free the volumes list (383 bytes, patch)
2015-04-02 03:33 UTC, David Liang 		reviewed Details | Review
following the instruction (737 bytes, patch)
2015-04-02 09:28 UTC, David Liang 		committed Details | Review

Description David Liang 2015-04-02 03:33:57 UTC 
Created attachment 300790 [details] [review]
free the volumes list

When we mount/umount a device for many times (>50 for example), the VmRSS of gvfs-hal-volume-monitor will be high.

The patch free the volumes list in 'should_drive_be_ignored'.
Comment 1 Ondrej Holy 2015-04-02 08:07:31 UTC 
Review of attachment 300790 [details] [review]:

Looks good, thanks! Just, could you make formatted patch instead of the diff? See:
https://wiki.gnome.org/Projects/GnomeShell/Development/WorkingWithPatches#How_to_make_a_patch
Comment 2 David Liang 2015-04-02 09:28:14 UTC 
Created attachment 300805 [details] [review]
following the instruction

Hi Ondrej,
New patch updated.
Comment 3 Ondrej Holy 2015-04-02 11:07:58 UTC 
Comment on attachment 300805 [details] [review]
following the instruction

commit 06677b95fddcd7973d296ff596031d7b9d890762
Comment 4 Ondrej Holy 2015-04-02 11:08:25 UTC 
Thanks!