After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747176 - [native-window-placement] Selection outline is drawn on top of the window label
[native-window-placement] Selection outline is drawn on top of the window label
Status: RESOLVED DUPLICATE of bug 758976
Product: gnome-shell
Classification: Core
Component: extensions
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 748084 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-04-01 13:04 UTC by Jan Alexander Steffens (heftig)
Modified: 2017-04-25 12:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Rise title on z index above border element to fix #747176 (998 bytes, patch)
2017-04-18 15:11 UTC, supremesyntax
none Details | Review
Raise window title on z index above border element (1.33 KB, patch)
2017-04-24 07:10 UTC, supremesyntax
none Details | Review

Description Jan Alexander Steffens (heftig) 2015-04-01 13:04:00 UTC
When the native window placement extension is enabled, the selection outline displayed on hover obscures the window label.

gnome-shell 3.16.0
gnome-shell-extensions 3.16.0
Comment 1 Florian Müllner 2015-04-17 22:14:33 UTC
*** Bug 748084 has been marked as a duplicate of this bug. ***
Comment 2 Vojtech Vladyka 2015-06-11 20:22:48 UTC
Same problem on Gnome Shell 3.14.1 with this extension.
Comment 3 b870705a 2015-07-07 11:36:03 UTC
I'm 3.16.2 (Debian), same problem here.
Comment 4 supremesyntax 2017-04-18 15:11:10 UTC
Created attachment 350007 [details] [review]
Rise title on z index above border element to fix #747176
Comment 5 Christoph Schulz 2017-04-23 09:11:06 UTC
Review of attachment 350007 [details] [review]:

The patch title seems to be wrong.
(You add the .raise instead of adding yourself to AUTHORS :D)
Comment 6 supremesyntax 2017-04-23 12:42:32 UTC
(In reply to Christoph Schulz from comment #5)
> Review of attachment 350007 [details] [review] [review]:
> 
> The patch title seems to be wrong.
> (You add the .raise instead of adding yourself to AUTHORS :D)

Yeah sorry i am new with git and did just blindly follow the tutorial @ https://wiki.gnome.org/Git/Developers :) 

How do we proceed? Can i change the commit title somehow?
I think i have to do a new commit right?
Comment 7 Florian Müllner 2017-04-23 19:37:15 UTC
$ git commit --amend

allows you to change the (top-most) commit - if you have other commits in the tree, you can use

$ git rebase -i origin/master

first to 'stop' at the commit in question (by marking it with 'edit').

(While speaking of commit messages: https://chris.beams.io/posts/git-commit/ provides some good guidance on the topic)
Comment 8 supremesyntax 2017-04-24 07:10:47 UTC
Created attachment 350283 [details] [review]
Raise window title on z index above border element
Comment 9 supremesyntax 2017-04-24 07:12:46 UTC
I fixed the title and added a short description to the patch.
Please review.
Comment 10 Florian Müllner 2017-04-24 09:38:51 UTC
Mmh, taking a closer look - the issue should have been fixed more than a year ago[0] ...

[0] https://git.gnome.org/browse/gnome-shell-extensions/commit/?id=2b9ea75
Comment 11 supremesyntax 2017-04-24 09:53:26 UTC
I have the latest version from extensions.gnome.org and your changes were not included there

Now that you mention it i see it in the git clone.
So it seems this bug is already solved.
Comment 12 Florian Müllner 2017-04-24 19:26:40 UTC
(In reply to supremesyntax from comment #11)
> I have the latest version from extensions.gnome.org and your changes were
> not included there

Are you sure? I'm seeing extension versions for 3.20, 3.22 and 3.24, all of which should have that change.

*** This bug has been marked as a duplicate of bug 758976 ***
Comment 13 supremesyntax 2017-04-25 11:42:02 UTC
I'm on Ubuntu 16.04.2 LTS
I am using GNOME Shell 3.18.5 so maybe it's missing for this version

extension version is "30" in metadata.json
Comment 14 Florian Müllner 2017-04-25 12:15:02 UTC
(In reply to supremesyntax from comment #13)
> I'm on Ubuntu 16.04.2 LTS
> I am using GNOME Shell 3.18.5 so maybe it's missing for this version

Yes, the patch landed in 3.20 - the versions mentioned in comment #12 weren't picked at random :-)