After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747155 - Wrong local name of Seoul
Wrong local name of Seoul
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: locations
unspecified
Other Linux
: Normal normal
: future
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks:
 
 
Reported: 2015-04-01 04:40 UTC by Changwoo Ryu
Modified: 2015-04-17 00:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix local name of seoul (763 bytes, patch)
2015-04-01 04:40 UTC, Changwoo Ryu 		committed Details | Review

Description Changwoo Ryu 2015-04-01 04:40:46 UTC 
Created attachment 300724 [details] [review]
Fix local name of seoul

In the comment of Seoul,

        <!-- The capital of South Korea.
             "Seoul" is the traditional English name.
             The local name in Korean is "Soul".
          -->

Obviously "Soul" is not a Korean word. It should be "서울".

Patch attached.
Comment 1 Bastien Nocera 2015-04-01 08:10:13 UTC 
Review of attachment 300724 [details] [review]:

::: data/Locations.xml.in
@@ +5694,3 @@
         <!-- The capital of South Korea.
              "Seoul" is the traditional English name.
+             The local name in Korean is "서울".

Except that then, only Koreans can read it.
How about:
The local name in Korean is "Soul" (서울)
?
Comment 2 Changwoo Ryu 2015-04-01 13:10:51 UTC 
(In reply to Bastien Nocera from comment #1)
> Review of attachment 300724 [details] [review] [review]:
> 
> ::: data/Locations.xml.in
> @@ +5694,3 @@
>          <!-- The capital of South Korea.
>               "Seoul" is the traditional English name.
> +             The local name in Korean is "서울".
> 
> Except that then, only Koreans can read it.
> How about:
> The local name in Korean is "Soul" (서울)
> ?

No, that is not a name "in Korean".

Other entries are also written in their own local scripts.
Comment 3 Giovanni Campagna 2015-04-17 00:22:59 UTC 
Hi, sorry for taking too long to review this patch.
I ended up committing something that should address both
sides: the local name is indicated in the local language,
as it makes sense, but the English transliteration is
preserved.