After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747140 - GDB-log syntax does not match all filenames
GDB-log syntax does not match all filenames
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
git master
Other All
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-31 21:02 UTC by Rudolf-Walter Kiss-Szakacs
Modified: 2015-04-13 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixing patch. (1.21 KB, patch)
2015-03-31 21:04 UTC, Rudolf-Walter Kiss-Szakacs 		accepted-commit_now Details | Review
Highlighting test file (3.75 KB, patch)
2015-04-02 14:03 UTC, Rudolf-Walter Kiss-Szakacs 		accepted-commit_now Details | Review

Description Rudolf-Walter Kiss-Szakacs 2015-03-31 21:02:01 UTC 
The GDB-log syntax only matches file names that contain nothing but letters, digits, underscores, slashes and dots. 

For file names that contain other characters, this results in a lack of highlighting -- not only for the file name itself, but also for the beginning of the next line.
Comment 1 Rudolf-Walter Kiss-Szakacs 2015-03-31 21:04:52 UTC 
Created attachment 300712 [details] [review]
Fixing patch.
Comment 2 Sébastien Wilmet 2015-04-01 16:43:18 UTC 
Review of attachment 300712 [details] [review]:

I didn't know that '?' can be used to minimize a quantifier, I've learned something new today :-)

The patch looks good, but can you provide or update an example in tests/syntax-highlighting/? So we can test more easily the change.
Comment 3 Rudolf-Walter Kiss-Szakacs 2015-04-02 14:03:20 UTC 
Created attachment 300817 [details] [review]
Highlighting test file

Note that this test file contains output that GDB generates with 'set logging on'. It includes only the output, not the echoed stdin or the '(gdb)' prompt.
Comment 4 Sébastien Wilmet 2015-04-13 13:31:14 UTC 
Review of attachment 300712 [details] [review]:

Ok, with the other commit this can be pushed.
Comment 5 Sébastien Wilmet 2015-04-13 13:31:33 UTC 
Review of attachment 300817 [details] [review]:

Looks good.