GNOME Bugzilla – Bug 747120
crash while trying to get tracks names
Last modified: 2015-05-26 13:20:23 UTC
Created attachment 300672 [details] console output on crash Using v3.14.0 on Archlinux 32 & 64 bits. I tried to encode the album Community Music from Asian Dub Foundation but contrary to other discs, this one makes sound-juicer crashing while trying to get the tracks name. I attached the console output after the crash. FYI, I tried disabling my network adapter, typed the tracks name manually, clicked extract and it worked.
Thanks for taking the time to report this. Can you get us a stack trace under gdb? Please see https://wiki.gnome.org/Community/GettingInTouch/Bugzilla/GettingTraces for more information on how to do so. When pasting a stack trace in this bug report, please reset the status of this bug report from NEEDINFO to its previous status. Thanks in advance!
As André said thanks for taking the time to report this. I think I've found the problem. One of the releases matching the discid[1] has no recording label, release country or release date details which due to a bug means sound-juicer is trying to free a static string. I'll attach a patch and push it as that bug needs fixing. Would you be able to check that it fixes your problem by building sound-juicer-git[2] from the aur and testing that it fixes your crash please. [1] https://musicbrainz.org/cdtoc/ZdNLaz3iD4y7TGYnrAQinUR9dkM [2] https://aur.archlinux.org/packages/so/sound-juicer-git/sound-juicer-git.tar.gz
Created attachment 300747 [details] [review] Fix a crash in multiple_album_dialog() The string returned by format_release_details() is freed in multiple_album_dialog() so the fallback string used when there are no extra release details needs to be copied before being returned.
Attachment 300747 [details] pushed as 76f1ffd - Fix a crash in multiple_album_dialog()
Hi there, Sorry for my late reply. I actually lent the album to a friend as I couldn't extract it, so currently I cannot provide more data neither run tests. I'll try to get the CD back and tell you if the patch fixed the crashing.
(In reply to Jeff from comment #5) > Hi there, > Sorry for my late reply. I actually lent the album to a friend as I couldn't > extract it, so currently I cannot provide more data neither run tests. > I'll try to get the CD back and tell you if the patch fixed the crashing. Hi Jeff, thanks for agreeing to test the fix, there's no great rush, I'll be offline next week anyway. Just post the result when you get a chance to run the test
(In reply to Jeff from comment #5) > Hi there, > Sorry for my late reply. I actually lent the album to a friend as I couldn't > extract it, so currently I cannot provide more data neither run tests. > I'll try to get the CD back and tell you if the patch fixed the crashing. Hi Jeff, the fix is in the 3.16.1 package on arch so now there's no need to build the aur package when you test it
Hi! I finally got the CD back for testing and I could extract the CD without crash :) Great job ! Thanks ! Marking the bug as resolved fixed.
(In reply to Jeff from comment #8) > Hi! I finally got the CD back for testing and I could extract the CD without > crash :) That's great, thanks for taking the time to test it.